bpo-32650: Add native coroutine support to bdb when stepping over line#5400
Conversation
|
Thank you for patch but tests are needed. |
|
@asvetlov I think is more complicated as coroutines are not iterable objects. Take for example |
|
I did mean not literal replacement but pointing on bdb tests style and required functionality. |
|
@asvetlov My bad, I did not understood your comment correctly. I will try to generate the required tests. Thanks for the comments :) |
|
No problem. |
|
@asvetlov In 97a0652 you will find a proposal for test style and functionality. I am invoking the coroutines though an event loop to avoid having to manually control the state with the |
|
This is the output without this patch for comparison: |
|
Looks perfect, please go ahead |
|
Andrew, I don't use pdb myself, so if you think the change is ok please feel free to merge it. |
|
Keep in mind that it's better to be merged now in order for it to make it to beta1. |
|
Sounds like a plan |
|
You can just manually advance a coroutine a with coro.send() method. |
|
@pablogsal I'm going to sleep. |
|
Thanks for contribution! |
|
Thanks @pablogsal for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
pythonGH-5400) (cherry picked from commit 4687702)
|
GH-5402 is a backport of this pull request to the 3.6 branch. |
|
Maybe you should also handle CO_ASYNC_GENERATOR flag. |
https://bugs.python.org/issue32650
CC: @asvetlov