Skip to content

bpo-27931: Fix email address header parsing error#5329

Merged
bitdancer merged 5 commits into
python:masterfrom
jayyyin:master
Jan 29, 2018
Merged

bpo-27931: Fix email address header parsing error#5329
bitdancer merged 5 commits into
python:masterfrom
jayyyin:master

Conversation

@jayyyin

@jayyyin jayyyin commented Jan 26, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@jayyyin jayyyin requested a review from a team as a code owner January 26, 2018 01:51
@the-knights-who-say-ni

the-knights-who-say-ni commented Jan 26, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

bitdancer
bitdancer requested changes Jan 26, 2018
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2018-01-25-21-04-11.bpo-27931.e4r52t.rst Outdated
@@ -0,0 +1 @@
Email parse IndexError <""@wiarcom.com> patch made by xiang.zhang

@bitdancer bitdancer Jan 26, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest: Fix email address header parsing error when the username is an empty quoted string. Patch by xian.zhang.

@bedevere-bot

bedevere-bot commented Jan 26, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@jayyyin

jayyyin commented Jan 26, 2018

Copy link
Copy Markdown
Contributor Author

did the change to the news file as requested

zhangyangyu
zhangyangyu reviewed Jan 26, 2018
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2018-01-25-21-04-11.bpo-27931.e4r52t.rst Outdated
@@ -0,0 +1 @@
Fix email address header parsing error when the username is an empty quoted string. Patch by xian.zhang.

@zhangyangyu zhangyangyu Jan 26, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, my name is Xiang Zhang.

@jayyyin

jayyyin commented Jan 26, 2018

Copy link
Copy Markdown
Contributor Author

fixed the typo in the name, sorry for not noticing the mistake

@jayyyin jayyyin changed the title bpo-27931adding patch set 3 to master bpo-27931 Fix email address header parsing error Jan 26, 2018
@zhangyangyu zhangyangyu changed the title bpo-27931 Fix email address header parsing error bpo-2793: Fix email address header parsing error Jan 26, 2018
@zhangyangyu zhangyangyu changed the title bpo-2793: Fix email address header parsing error bpo-27931: Fix email address header parsing error Jan 26, 2018
@bitdancer bitdancer merged commit aa218d1 into python:master Jan 29, 2018
@bedevere-bot

bedevere-bot commented Jan 29, 2018

Copy link
Copy Markdown

@bitdancer: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Jan 29, 2018

Copy link
Copy Markdown
Contributor

Thanks @jayyyin for the PR, and @bitdancer for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 29, 2018
@jayyyin @miss-islington
bpo-27931: Fix email address header parsing error (pythonGH-5329)
803c14d 
Correctly handle addresses whose username is an empty quoted string.
(cherry picked from commit aa218d1)
@bedevere-bot

bedevere-bot commented Jan 29, 2018

Copy link
Copy Markdown

GH-5431 is a backport of this pull request to the 3.6 branch.

Mariatta pushed a commit that referenced this pull request Jan 29, 2018
@miss-islington @jayyyin @Mariatta
bpo-27931: Fix email address header parsing error (GH-5329) (GH-5431)
6ea75b1 
Correctly handle addresses whose username is an empty quoted string.
(cherry picked from commit aa218d1)

Co-authored-by: jayyyin <jayyin11043@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangyangyu zhangyangyu zhangyangyu left review comments

@bitdancer bitdancer bitdancer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jayyyin @the-knights-who-say-ni @bedevere-bot @miss-islington @bitdancer @zhangyangyu