Skip to content

bpo-32015: Asyncio looping during simultaneously socket read/write an…#4386

Merged
asvetlov merged 5 commits into
python:masterfrom
andr-04:fix-issue-32015
Nov 14, 2017
Merged

bpo-32015: Asyncio looping during simultaneously socket read/write an…#4386
asvetlov merged 5 commits into
python:masterfrom
andr-04:fix-issue-32015

Conversation

@andr-04

@andr-04 andr-04 commented Nov 13, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

@andr-04 andr-04 requested a review from 1st1 as a code owner November 13, 2017 13:12
@the-knights-who-say-ni

the-knights-who-say-ni commented Nov 13, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@andr-04 andr-04 changed the title bpo-32015: Asyncio cycling during simultaneously socket read/write an… bpo-32015: Asyncio looping during simultaneously socket read/write an… Nov 13, 2017
@1st1

1st1 commented Nov 13, 2017

Copy link
Copy Markdown
Member

Looks good to me, but we need a unit test. A functional one, ideally.

asvetlov
asvetlov requested changes Nov 13, 2017
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to stress @1st1 note: a new test is required.

Otherwise we could break the proposed feature easy by future refactoring at least.

@bedevere-bot

bedevere-bot commented Nov 13, 2017

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@andr-04

andr-04 commented Nov 14, 2017

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Nov 14, 2017

Copy link
Copy Markdown

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@asvetlov asvetlov merged commit e1d62e0 into python:master Nov 14, 2017
@miss-islington

miss-islington commented Nov 14, 2017

Copy link
Copy Markdown
Contributor

Thanks @andr-04 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Nov 14, 2017

Copy link
Copy Markdown
Contributor

Sorry, @andr-04 and @asvetlov, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e1d62e0b7cc842d6b75b4d480391f4a94e503255 3.6

@andr-04

andr-04 commented Nov 14, 2017

Copy link
Copy Markdown
Contributor Author

@asvetlov, What about Python 3.5?

@asvetlov

asvetlov commented Nov 14, 2017

Copy link
Copy Markdown
Contributor

Python 3.5 is in security mode, the current policy for bugfix backporting is applied to 3.6 only.

@andr-04 andr-04 deleted the fix-issue-32015 branch November 14, 2017 09:44
asvetlov pushed a commit to asvetlov/cpython that referenced this pull request Nov 14, 2017
@andr-04 @asvetlov
[3.6] bpo-32015: Asyncio looping during simultaneously socket read/wr…
f50d2e2 
…ite an… (pythonGH-4386)

* bpo-32015: Asyncio cycling during simultaneously socket read/write and reconnection

* Tests fix

* Tests fix

* News add

* Add new unit tests.
(cherry picked from commit e1d62e0)
@asvetlov asvetlov mentioned this pull request Nov 14, 2017
Merged
@bedevere-bot

bedevere-bot commented Nov 14, 2017

Copy link
Copy Markdown

GH-4393 is a backport of this pull request to the 3.6 branch.

asvetlov added a commit that referenced this pull request Nov 14, 2017
@asvetlov
[3.6] bpo-32015: Asyncio looping during simultaneously socket read/wr…
cc0961c 
…ite an… (GH-4386) (#4393)

* bpo-32015: Asyncio cycling during simultaneously socket read/write and reconnection

* Tests fix

* Tests fix

* News add

* Add new unit tests.
(cherry picked from commit e1d62e0)
@1st1

1st1 commented Nov 14, 2017

Copy link
Copy Markdown
Member

I actually asked for a functional test, not a mocked one. @andr-04 can you add one in a separate PR?

@andr-04

andr-04 commented Nov 14, 2017

Copy link
Copy Markdown
Contributor Author

I'll try. The reproducing script is there if you are interested in.

@andr-04 andr-04 mentioned this pull request Jun 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andr-04 @the-knights-who-say-ni @1st1 @bedevere-bot @miss-islington @asvetlov