Skip to content

bpo-31903: Release the GIL when calling into SystemConfiguration#4178

Merged
benjaminp merged 3 commits into
python:masterfrom
maxbelanger:fix-issue-31903
Sep 11, 2018
Merged

bpo-31903: Release the GIL when calling into SystemConfiguration#4178
benjaminp merged 3 commits into
python:masterfrom
maxbelanger:fix-issue-31903

Conversation

@maxbelanger

@maxbelanger maxbelanger commented Oct 30, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Per details in issue tracker, make sure we release the GIL when calling SCDynamicStoreCopyProxies to avoid potential deadlocking if other Python threads also call into NSUserDefaults.

https://bugs.python.org/issue31903

@maxbelanger
bpo-31903: Release the GIL when calling into SystemConfiguration
5b104ca 
Make sure we release the GIL when calling `SCDynamicStoreCopyProxies` to avoid potential deadlocking if other Python  threads also call into `NSUserDefaults`.
ronaldoussoren
ronaldoussoren approved these changes Nov 29, 2017
View reviewed changes

@ronaldoussoren ronaldoussoren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good.

@maxbelanger

maxbelanger commented Jan 8, 2018

Copy link
Copy Markdown
Contributor Author

@ronaldoussoren any updates on whether this can be merged?

@benjaminp benjaminp merged commit 4859ba0 into python:master Sep 11, 2018
@miss-islington

miss-islington commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

Thanks @maxbelanger for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

Thanks @maxbelanger for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

Thanks @maxbelanger for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2018
@maxbelanger @miss-islington
closes bpo-31903: Release the GIL when calling into SystemConfigurati…
377d38e 
…on (pythonGH-4178)

(cherry picked from commit 4859ba0)

Co-authored-by: Max Bélanger <aeromax@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 12, 2018

Copy link
Copy Markdown

GH-9215 is a backport of this pull request to the 3.6 branch.

@miss-islington

miss-islington commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

Sorry, @maxbelanger and @benjaminp, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4859ba0d2ce4506fddc3f55f90f8dce031b3804f 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2018
@maxbelanger @miss-islington
closes bpo-31903: Release the GIL when calling into SystemConfigurati…
11f3e91 
…on (pythonGH-4178)

(cherry picked from commit 4859ba0)

Co-authored-by: Max Bélanger <aeromax@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 12, 2018

Copy link
Copy Markdown

GH-9216 is a backport of this pull request to the 3.7 branch.

@miss-islington

miss-islington commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

Thanks @maxbelanger for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington added a commit that referenced this pull request Sep 12, 2018
@miss-islington @maxbelanger
closes bpo-31903: Release the GIL when calling into SystemConfigurati…
72c34cf 
…on (GH-4178)

(cherry picked from commit 4859ba0)

Co-authored-by: Max Bélanger <aeromax@gmail.com>
miss-islington added a commit that referenced this pull request Sep 12, 2018
@miss-islington @maxbelanger
closes bpo-31903: Release the GIL when calling into SystemConfigurati…
aa12534 
…on (GH-4178)

(cherry picked from commit 4859ba0)

Co-authored-by: Max Bélanger <aeromax@gmail.com>
@maxbelanger maxbelanger deleted the fix-issue-31903 branch October 26, 2018 23:08
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error and removed needs backport to 3.7 labels Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@maxbelanger @miss-islington @bedevere-bot @ronaldoussoren @benjaminp @serhiy-storchaka @the-knights-who-say-ni