[3.6] bpo-21720: Restore the Python 2.7 logic in handling a fromlist. (GH-4118)#4128
Merged
serhiy-storchaka merged 1 commit intoOct 26, 2017
Merged
Conversation
…pythonGH-4118) BytesWarning no longer emitted when the fromlist argument of __import__() or the __all__ attribute of the module contain bytes instances.. (cherry picked from commit 41c5694)
taleinat
approved these changes
Oct 26, 2017
taleinat
left a comment
Contributor
There was a problem hiding this comment.
LGTM: Seems identical to the 3.7 commit, everything looks okay, all tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BytesWarning no longer emitted when the fromlist argument of
__import__()or the__all__attribute of the module contain bytesinstances..
(cherry picked from commit 41c5694)
https://bugs.python.org/issue21720