[3.6] bpo-31672: Fix string.Template accidentally matched non-ASCII identifiers (GH-3872)#3982
Merged
Merged
Conversation
…dentifiers (pythonGH-3872) Pattern `[a-z]` with `IGNORECASE` flag can match to some non-ASCII characters. Straightforward solution for this is using `IGNORECASE | ASCII` flag. But users may subclass `Template` and override only `idpattern`. So we want to avoid changing `Template.flags`. So this commit uses local flag `-i` for `idpattern` and change `[a-z]` to `[a-zA-Z]`.. (cherry picked from commit b22273e)
warsaw
reviewed
Oct 13, 2017
|
|
||
| While *flags* is kept to ``re.IGNORECASE`` for backward compatibility, | ||
| you can override it to ``0`` or ``re.IGNORECASE | re.ASCII`` when | ||
| subclassing. It's simple way to avoid unexpected match like above example. |
Member
There was a problem hiding this comment.
This last sentence ("It's...") has some grammatical problems, and I don't think it's actually necessary. Can you remove it please?
methane
added a commit
to methane/cpython
that referenced
this pull request
Oct 14, 2017
This sentence is removed while backporting to 3.6 branch. See python#3982 (comment)
methane
added a commit
that referenced
this pull request
Oct 14, 2017
This sentence is removed while backporting to 3.6 branch. See #3982 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pattern
[a-z]withIGNORECASEflag can match to some non-ASCII characters.Straightforward solution for this is using
IGNORECASE | ASCIIflag.But users may subclass
Templateand override onlyidpattern. So we want toavoid changing
Template.flags.So this commit uses local flag
-iforidpatternand change[a-z]to[a-zA-Z]..(cherry picked from commit b22273e)
https://bugs.python.org/issue31672