Skip to content

bpo-25862: Fix an assertion failure in io.TextIOWrapper.tell().#3918

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
ZackerySpytz:bpo-25862-assertion-failure
Jun 29, 2018
Merged

bpo-25862: Fix an assertion failure in io.TextIOWrapper.tell().#3918
serhiy-storchaka merged 2 commits into
python:masterfrom
ZackerySpytz:bpo-25862-assertion-failure

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Oct 7, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Calling read() can call Py_CLEAR(self->snapshot), but self->decoded_chars is not set to NULL in this case. This can cause an assertion failure in tell().

https://bugs.python.org/issue25862

@ZackerySpytz ZackerySpytz force-pushed the bpo-25862-assertion-failure branch from 33e3a5e to 5fd8540 Compare June 23, 2018 12:02
serhiy-storchaka
serhiy-storchaka reviewed Jun 27, 2018
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @ZackerySpytz. It fixes the original case. But there are other similar cases, and it would be nice to fix them in a single issue. It is enough to fix tell() after write(). Other cases look less rare and more complex. They can be fixed in separate PRs.

Comment thread Lib/test/test_io.py Outdated

def test_issue25862(self):
# tell() shouldn't cause an assertion failure if called after read().
t = self.TextIOWrapper(self.BytesIO(b'test'))

@serhiy-storchaka serhiy-storchaka Jun 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The encoding depends on the environment. This can affect the test. It is better to specify the encoding explicitly.

@ZackerySpytz ZackerySpytz force-pushed the bpo-25862-assertion-failure branch from eac030f to d00fa36 Compare June 29, 2018 00:02
@ZackerySpytz ZackerySpytz force-pushed the bpo-25862-assertion-failure branch from d00fa36 to 3066cf8 Compare June 29, 2018 03:20
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Jun 29, 2018
@serhiy-storchaka serhiy-storchaka merged commit 23db935 into python:master Jun 29, 2018
@miss-islington

miss-islington commented Jun 29, 2018

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2018
@ZackerySpytz @miss-islington
bpo-25862: Fix assertion failures in io.TextIOWrapper.tell(). (python…
0c1f53c 
…GH-3918)

(cherry picked from commit 23db935)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

bedevere-bot commented Jun 29, 2018

Copy link
Copy Markdown

GH-8007 is a backport of this pull request to the 3.7 branch.

@miss-islington

miss-islington commented Jun 29, 2018

Copy link
Copy Markdown
Contributor

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 23db935bcf258657682e66464bf8512def8af830 2.7

@miss-islington

miss-islington commented Jun 29, 2018

Copy link
Copy Markdown
Contributor

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 23db935bcf258657682e66464bf8512def8af830 3.6

miss-islington added a commit that referenced this pull request Jun 29, 2018
@miss-islington @ZackerySpytz
bpo-25862: Fix assertion failures in io.TextIOWrapper.tell(). (GH-3918)
eabebbb 
(cherry picked from commit 23db935)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
ZackerySpytz added a commit to ZackerySpytz/cpython that referenced this pull request Jun 29, 2018
@ZackerySpytz
[3.6] bpo-25862: Fix assertion failures in io.TextIOWrapper.tell(). (p…
a8991f1 
…ythonGH-3918).

(cherry picked from commit 23db935)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

bedevere-bot commented Jun 29, 2018

Copy link
Copy Markdown

GH-8012 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka pushed a commit that referenced this pull request Jun 29, 2018
@ZackerySpytz @serhiy-storchaka
[3.6] bpo-25862: Fix assertion failures in io.TextIOWrapper.tell(). (G…
d6a283b 
…H-3918). (GH-8012)

(cherry picked from commit 23db935)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
ZackerySpytz added a commit to ZackerySpytz/cpython that referenced this pull request Jun 29, 2018
@ZackerySpytz
[2.7] bpo-25862: Fix assertion failures in io.TextIOWrapper.tell(). (p…
4e28041 
…ythonGH-3918).

(cherry picked from commit 23db935)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

bedevere-bot commented Jun 29, 2018

Copy link
Copy Markdown

GH-8013 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka pushed a commit that referenced this pull request Jun 29, 2018
@ZackerySpytz @serhiy-storchaka
[2.7] bpo-25862: Fix assertion failures in io.TextIOWrapper.tell(). (G…
0464de0 
…H-3918). (GH-8013)

(cherry picked from commit 23db935)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@ZackerySpytz ZackerySpytz deleted the bpo-25862-assertion-failure branch June 30, 2018 17:18
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZackerySpytz @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni