bpo-23702: Update Descriptor-HOWTO to reflect the removal of unbound … #3739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Maybe now would be a good time to take a look at https://bugs.python.org/issue17894 ? |
serhiy-storchaka
approved these changes
Sep 25, 2017
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I'm not competent in reviewing English, but overall look good to me. Except one suspicious place.
| are written using :keyword:`def` and :keyword:`lambda`, the usual tools for | ||
| creating functions. The only difference from regular functions is that the | ||
| are written using :keyword:`def` or :keyword:`lambda`, the usual tools for | ||
| creating functions. Methods only differ from regular functions in that the |
Member
There was a problem hiding this comment.
I'm not sure about "in that".
|
|
||
| >>> class D(object): | ||
| ... def f(self, x): | ||
| ... return x |
Member
There was a problem hiding this comment.
(object) above can be removed.
Member
Sure. Look also at https://bugs.python.org/issue26103. |
Contributor
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-3742 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 25, 2017
…bound methods (pythonGH-3739) (cherry picked from commit 0d4497b)
rhettinger
pushed a commit
that referenced
this pull request
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue23702