bpo-28556: typing.get_type_hints: better globalns for classes and modules#3582
Merged
ambv merged 1 commit intopython:masterfrom Sep 14, 2017
Merged
bpo-28556: typing.get_type_hints: better globalns for classes and modules#3582ambv merged 1 commit intopython:masterfrom
ambv merged 1 commit intopython:masterfrom
Conversation
…ules This makes the default behavior (without specifying `globalns` manually) more predictable for users, finds the right globalns automatically. Implementation for classes assumes has a `__module__` attribute and that module is present in `sys.modules`. It does this recursively for all bases in the MRO. For modules, the implementation just uses their `__dict__` directly. This is backwards compatible, will just raise fewer exceptions in naive user code. Originally implemented and reviewed at python/typing#470.
Contributor
Author
|
cc @ilevkivskyi. |
ilevkivskyi
approved these changes
Sep 14, 2017
Contributor
|
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-3583 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 14, 2017
…nd modules (pythonGH-3582) This makes the default behavior (without specifying `globalns` manually) more predictable for users, finds the right globalns automatically. Implementation for classes assumes has a `__module__` attribute and that module is present in `sys.modules`. It does this recursively for all bases in the MRO. For modules, the implementation just uses their `__dict__` directly. This is backwards compatible, will just raise fewer exceptions in naive user code. Originally implemented and reviewed at python/typing#470. (cherry picked from commit f350a26)
ambv
pushed a commit
that referenced
this pull request
Sep 14, 2017
…nd modules (GH-3582) (#3583) This makes the default behavior (without specifying `globalns` manually) more predictable for users, finds the right globalns automatically. Implementation for classes assumes has a `__module__` attribute and that module is present in `sys.modules`. It does this recursively for all bases in the MRO. For modules, the implementation just uses their `__dict__` directly. This is backwards compatible, will just raise fewer exceptions in naive user code. Originally implemented and reviewed at python/typing#470. (cherry picked from commit f350a26)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the default behavior (without specifying
globalnsmanually) morepredictable for users, finds the right globalns automatically.
Implementation for classes assumes has a
__module__attribute and that moduleis present in
sys.modules. It does this recursively for all bases in theMRO. For modules, the implementation just uses their
__dict__directly.This is backwards compatible, will just raise fewer exceptions in naive user
code.
Originally implemented and reviewed at python/typing#470.
https://bugs.python.org/issue28556