Skip to content

[3.6] bpo-31249: Fix test_concurrent_futures dangling thread (GH-3521)#3522

Merged
vstinner merged 1 commit into
python:3.6from
miss-islington:backport-3bcf157-3.6
Sep 13, 2017
Merged

[3.6] bpo-31249: Fix test_concurrent_futures dangling thread (GH-3521)#3522
vstinner merged 1 commit into
python:3.6from
miss-islington:backport-3bcf157-3.6

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

ProcessPoolShutdownTest.test_del_shutdown() now closes the call queue
and joins its thread, to prevent leaking a dangling thread.
(cherry picked from commit 3bcf157)

https://bugs.python.org/issue31249

…H-3521)

ProcessPoolShutdownTest.test_del_shutdown() now closes the call queue
and joins its thread, to prevent leaking a dangling thread.
(cherry picked from commit 3bcf157)
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 94eb2d5 into python:3.6 Sep 13, 2017
@miss-islington

Copy link
Copy Markdown
Contributor Author

Thanks, @Haypo!

@miss-islington miss-islington deleted the backport-3bcf157-3.6 branch September 13, 2017 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants