bpo-30860: Fix deadcode in obmalloc.c #3499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm not sure why this change is needed since Include/internal/pymalloc.h contains: So the code is already dead code? Maybe the code should be removed, but add a comment to Include/internal/pymalloc.h to ask to update _PyMem_Initialize() if NB_SMALL_SIZE_CLASSES becomes larger than 64? |
Member
|
So is coverity not smart enough to figure out the check across files? Or perhaps the coverity whitelist needs to be updated? |
Fix Coverity CID 1417587: _PyMem_Initialize() contains code which is never executed. Replace the runtime check with a build assertion.
Member
Author
|
I rewrote the PR to remove the deadcode. I added a build assertion as a reminder to update the code if NB_SMALL_SIZE_CLASSES is modified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Coverity CID 1417587: _PyMem_Initialize() contains code which is
never executed.
https://bugs.python.org/issue30860