Skip to content

bpo-31400: Improve SSL error handling on Windows#3463

Merged
tiran merged 2 commits into
python:masterfrom
zooba:ssl_errno
Sep 8, 2017
Merged

bpo-31400: Improve SSL error handling on Windows#3463
tiran merged 2 commits into
python:masterfrom
zooba:ssl_errno

Conversation

@zooba

@zooba zooba commented Sep 8, 2017

Copy link
Copy Markdown
Member

@@ -0,0 +1 @@
Improves SSL error handling on Windows to avoid losing error numbers.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/on Windows//

@tiran tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please address the minor nit pick in Mews/NEWS.d.

@tiran tiran merged commit e6eb48c into python:master Sep 8, 2017
@miss-islington

Copy link
Copy Markdown
Contributor

🐍🍒⛏🤖 Thanks @zooba for the PR, and @tiran for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @zooba and @tiran, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.

@bedevere-bot

Copy link
Copy Markdown

GH-3466 is a backport of this pull request to the 3.6 branch.

tiran pushed a commit to tiran/cpython that referenced this pull request Sep 8, 2017
* bpo-31392: Improve SSL error handling on Windows

* Remove unnecessary Windows mention in NEWS.
(cherry picked from commit e6eb48c)
@zooba zooba deleted the ssl_errno branch September 8, 2017 23:00
tiran added a commit that referenced this pull request Sep 9, 2017
* bpo-31392: Improve SSL error handling on Windows

* Remove unnecessary Windows mention in NEWS.
(cherry picked from commit e6eb48c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OS-windows sprint type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants