Skip to content

bpo-29781: Fix SSLObject.version before handshake#3364

Merged
tiran merged 1 commit into
python:masterfrom
tiran:bpo-29781_sslobject_version_bio
Sep 6, 2017
Merged

bpo-29781: Fix SSLObject.version before handshake#3364
tiran merged 1 commit into
python:masterfrom
tiran:bpo-29781_sslobject_version_bio

Conversation

@tiran

@tiran tiran commented Sep 5, 2017

Copy link
Copy Markdown
Member

SSLObject.version() now correctly returns None when handshake over BIO has
not been performed yet.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue29781

SSLObject.version() now correctly returns None when handshake over BIO has
not been performed yet.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran merged commit 6877111 into python:master Sep 6, 2017
@miss-islington

Copy link
Copy Markdown
Contributor

🐍🍒⛏🤖 Thanks @tiran for the PR, and @tiran for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

@tiran tiran deleted the bpo-29781_sslobject_version_bio branch September 6, 2017 04:55
tiran added a commit to tiran/cpython that referenced this pull request Sep 6, 2017
SSLObject.version() now correctly returns None when handshake over BIO has
not been performed yet.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 6877111)
@bedevere-bot

Copy link
Copy Markdown

GH-3381 is a backport of this pull request to the 3.6 branch.

tiran added a commit that referenced this pull request Sep 6, 2017
)

SSLObject.version() now correctly returns None when handshake over BIO has
not been performed yet.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 6877111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-security A security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants