bpo-30781: IDLE: Fix help button on configdialog #3238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryjreedy
approved these changes
Sep 11, 2017
Member
terryjreedy
left a comment
There was a problem hiding this comment.
Problem fixed: help works for all 5 tabs.
Member
|
I approved this without a new test because adding automated testing for the buttons is already part of bpo-30780 and because I want this fixed now ;-). |
Contributor
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2017
This fixes an omission in the ttk conversion patch for this issue, hence no new news. Patch by Cheryl Sabella. (cherry picked from commit 3866d9b)
|
GH-3489 is a backport of this pull request to the 3.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The help button wasn't changed from
tab_pagestonote.https://bugs.python.org/issue30781