bpo-31286: Fixed stack usage in absolute imports with binding a submo… #3217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
621bfd3 to
97dd426
Compare
brettcannon
approved these changes
Aug 28, 2017
Member
brettcannon
left a comment
There was a problem hiding this comment.
LGTM.
Should we bump the magic number for this?
Contributor
|
Yes, we should bump the magic number, as otherwise cached pyc files will still exhibit the bug - we need the interpreter to clear them out and recompile them. |
Member
Author
|
I'm not sure this is needed. The version with the bug was not released. The bug affects only pre-alpha testers. AFAIK there are no precedences of bumping the magic number at pre-alpha stage for fixing a bug. |
Contributor
|
Fair point, especially as the new test case is the only example of the problem in the code base. We can probably skip the NEWS entry for the same reason (i.e. it fixes a bug in never-released code, so the fact the bug existed isn't exactly relevant to most users) |
GadgetSteve
pushed a commit
to GadgetSteve/cpython
that referenced
this pull request
Sep 10, 2017
…hon#3217) binding a submodule to a name.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dule to a name.
https://bugs.python.org/issue30024