Skip to content

bpo-46676: Make ParamSpec args and kwargs equal to themselves#31203

Merged
serhiy-storchaka merged 7 commits intopython:mainfrom
GBeauregard:fix-paramspec-equality
Feb 8, 2022
Merged

bpo-46676: Make ParamSpec args and kwargs equal to themselves#31203
serhiy-storchaka merged 7 commits intopython:mainfrom
GBeauregard:fix-paramspec-equality

Conversation

@GBeauregard
Copy link
Copy Markdown
Contributor

@GBeauregard GBeauregard commented Feb 7, 2022 •
edited by bedevere-bot
Loading

Accomplished by adding __eq__ methods in a manner that mirrors similar methods in other parts of typing.py.

https://bugs.python.org/issue46676

@GBeauregard GBeauregard marked this pull request as ready for review February 7, 2022 19:55
sobolevn
sobolevn reviewed Feb 7, 2022
View reviewed changes
@GBeauregard GBeauregard requested a review from sobolevn February 7, 2022 20:33
sobolevn
sobolevn reviewed Feb 8, 2022
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Feb 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.10 only security fixes label Feb 8, 2022
@serhiy-storchaka serhiy-storchaka merged commit c8b62bb into python:main Feb 8, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 8, 2022

Thanks @GBeauregard for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 8, 2022

Sorry @GBeauregard and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c8b62bbe46e20d4b6dd556f2fa85960d1269aa45 3.10

@GBeauregard
Copy link
Copy Markdown
Contributor Author

GBeauregard commented Feb 8, 2022

@serhiy-storchaka thanks, I will run the cherry picker for you and open a PR

GBeauregard added a commit to GBeauregard/cpython that referenced this pull request Feb 8, 2022
@GBeauregard
[3.10] bpo-46676: Make ParamSpec args and kwargs equal to themselves (p…
349b745 
…ythonGH-31203)

(cherry picked from commit c8b62bb)

Co-authored-by: Gregory Beauregard <greg@greg.red>
@GBeauregard GBeauregard mentioned this pull request Feb 8, 2022
Merged
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 8, 2022
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 8, 2022

GH-31210 is a backport of this pull request to the 3.10 branch.

serhiy-storchaka pushed a commit that referenced this pull request Feb 8, 2022
@GBeauregard
[3.10] bpo-46676: Make ParamSpec args and kwargs equal to themselves (G…
cbdcae5 
…H-31203) (GH-31210)

(cherry picked from commit c8b62bb)

Co-authored-by: Gregory Beauregard <greg@greg.red>
@GBeauregard GBeauregard mentioned this pull request Feb 8, 2022
Merged
@serhiy-storchaka serhiy-storchaka removed their assignment Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GBeauregard @miss-islington @bedevere-bot @serhiy-storchaka @sobolevn @the-knights-who-say-ni