bpo-44359: Fix test_ftplib unhandled thread exceptions #31069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_ftplib now silently ignores socket errors to prevent logging unhandled threading exceptions.
Member
Author
|
Without this PR, With this PR, this command pass and |
JelleZijlstra
approved these changes
Feb 2, 2022
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 2, 2022
test_ftplib now silently ignores socket errors to prevent logging unhandled threading exceptions. (cherry picked from commit 0611eaf) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-31070 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 2, 2022
test_ftplib now silently ignores socket errors to prevent logging unhandled threading exceptions. (cherry picked from commit 0611eaf) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-31071 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 2, 2022
miss-islington
added a commit
that referenced
this pull request
Feb 2, 2022
Member
Author
Thanks for the post merge reviw, I appreciate it, it makes me more confident :-) I wrote a long rationale in the bpo. |
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
test_ftplib now silently ignores socket errors to prevent logging unhandled threading exceptions. (cherry picked from commit 0611eaf) Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_ftplib now silently ignores socket errors to prevent logging
unhandled threading exceptions.
https://bugs.python.org/issue44359