Skip to content

bpo-30824: Add .json mimetype#3048

Merged
bitdancer merged 1 commit into
python:masterfrom
e4r7hbug:feat/mimetypes_json
Aug 14, 2017
Merged

bpo-30824: Add .json mimetype#3048
bitdancer merged 1 commit into
python:masterfrom
e4r7hbug:feat/mimetypes_json

Conversation

@e4r7hbug

@e4r7hbug e4r7hbug commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

The .json extension should have a recognized mimetype as registered by the IANA.

See discussion: https://mail.python.org/pipermail/python-ideas/2017-August/046666.html

https://bugs.python.org/issue30824

@e4r7hbug e4r7hbug requested a review from bitdancer as a code owner August 9, 2017 19:00
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@brettcannon

Copy link
Copy Markdown
Member

Sorry about all the redundant approvals, @e4r7hbug , but your PR was simple enough that I could make sure the PR wasn't wasted by me approving it and I needed to test something (the new "awaiting merge" label 😄 ).

@bitdancer bitdancer merged commit 8204b90 into python:master Aug 14, 2017
@sijis

sijis commented Aug 14, 2017

Copy link
Copy Markdown

Is backporting done automatically or is a new PR necessary?

@brettcannon

Copy link
Copy Markdown
Member

New PRs are necessary. Not sure if @bitdancer was planning to do that still, although if you want to do it, @sijis, I'm sure he wouldn't mind the help. 😄

@sijis

sijis commented Aug 14, 2017

Copy link
Copy Markdown

Yeah, I'd love to try.

@brettcannon

Copy link
Copy Markdown
Member

@sijis then go for it! Have a look at https://github.com/python/core-workflow/tree/master/cherry_picker as that's what we use to create backport PRs (there will also be details in the devguide). The key thing, though, is getting the title formatted properly as we have webhooks in GitHub to connect the backport PRs back to this PR and remove the "backport" labels automatically.

@miss-islington

Copy link
Copy Markdown
Contributor

🐍🍒⛏🤖 Thanks @e4r7hbug for the PR, and @bitdancer for merging it 🌮🎉.I'm working now to backport this PR to: 2.7, 3.6.

@bedevere-bot

Copy link
Copy Markdown

GH-3394 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 6, 2017
bitdancer pushed a commit that referenced this pull request Sep 6, 2017
@miss-islington

Copy link
Copy Markdown
Contributor

🐍🍒⛏🤖 Thanks @e4r7hbug for the PR, and @bitdancer for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 6, 2017
@bedevere-bot

Copy link
Copy Markdown

GH-3401 is a backport of this pull request to the 3.6 branch.

bitdancer pushed a commit that referenced this pull request Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants