bpo-23819: Get rid of assert statements in test_asyncio#30212
Merged
serhiy-storchaka merged 1 commit intopython:mainfrom Dec 20, 2021
Merged
bpo-23819: Get rid of assert statements in test_asyncio#30212serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka merged 1 commit intopython:mainfrom
Conversation
To keep checks even if run tests with optimized Python. Either use special assertion methods like assertEqual() or raise an AssertionError explicitly.
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 406593c 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-30213 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 20, 2021
To keep checks even if run tests with optimized Python. Either use special assertion methods like assertEqual() or raise an AssertionError explicitly. (cherry picked from commit 6ca78af) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
brandtbucher
pushed a commit
to brandtbucher/cpython
that referenced
this pull request
Dec 27, 2021
To keep checks even if run tests with optimized Python. Either use special assertion methods like assertEqual() or raise an AssertionError explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To keep checks even if run tests with optimized Python.
Either use special assertion methods like assertEqual() or
raise an AssertionError explicitly.
https://bugs.python.org/issue23819