Skip to content

bpo-23819: Fix asyncio tests on python optimized mode#30195

Merged
serhiy-storchaka merged 5 commits intopython:mainfrom
kumaraditya303:issue23819
Dec 26, 2021
Merged

bpo-23819: Fix asyncio tests on python optimized mode#30195
serhiy-storchaka merged 5 commits intopython:mainfrom
kumaraditya303:issue23819

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 19, 2021 •
edited by bedevere-bot
Loading

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Dec 19, 2021

cc @asvetlov

serhiy-storchaka
serhiy-storchaka reviewed Dec 19, 2021
View reviewed changes
asvetlov
asvetlov requested changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I agree, public faced assertions should be converted to explicit errors.
But internal invariant checks like assert self._buffer in _write_ready() method should be untouched.
If this particular assertion breaks tests with -O mode -- the check should be skipped if sys.flags.optimize is set.

@bedevere-bot
Copy link

bedevere-bot commented Dec 19, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Dec 20, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Dec 20, 2021

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed Dec 20, 2021
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Dec 21, 2021
View reviewed changes
@serhiy-storchaka serhiy-storchaka added needs backport to 3.9 needs backport to 3.10 only security fixes tests Tests in the Lib/test dir labels Dec 26, 2021
@serhiy-storchaka serhiy-storchaka merged commit a23ab7b into python:main Dec 26, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Dec 26, 2021

Thanks @kumaraditya303 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 26, 2021

Sorry @kumaraditya303 and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a23ab7b6d8b3ae3a47747c0c4bceb2370cc48dcc 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 26, 2021
@kumaraditya303 @miss-islington
bpo-23819: Fix asyncio tests on python optimized mode (pythonGH-30195)
abc2721 
(cherry picked from commit a23ab7b)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 26, 2021

GH-30265 is a backport of this pull request to the 3.9 branch.

serhiy-storchaka pushed a commit that referenced this pull request Dec 26, 2021
@miss-islington @kumaraditya303
[3.9] bpo-23819: Fix asyncio tests on python optimized mode (GH-30195) (
0722905 
GH-30265)

(cherry picked from commit a23ab7b)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303 kumaraditya303 deleted the issue23819 branch December 27, 2021 08:25
@kumaraditya303 kumaraditya303 restored the issue23819 branch December 27, 2021 08:25
@kumaraditya303 kumaraditya303 deleted the issue23819 branch December 27, 2021 08:25
@kumaraditya303 kumaraditya303 restored the issue23819 branch December 27, 2021 08:25
@serhiy-storchaka serhiy-storchaka removed their assignment Nov 10, 2023
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.10 only security fixes label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kumaraditya303 @bedevere-bot @miss-islington @asvetlov @serhiy-storchaka @the-knights-who-say-ni