Move error test to function that needs it. Improve error message.#30008
Merged
rhettinger merged 25 commits intopython:mainfrom Dec 10, 2021
Merged
Move error test to function that needs it. Improve error message.#30008rhettinger merged 25 commits intopython:mainfrom
rhettinger merged 25 commits intopython:mainfrom
Conversation
Update to 15 March
llimeht
reviewed
Dec 6, 2022
| def choice(self, seq): | ||
| """Choose a random element from a non-empty sequence.""" | ||
| # raises IndexError if seq is empty | ||
| if not seq: |
There was a problem hiding this comment.
@rhettinger : This change prevents operation on numpy arrays: if not seq will produce a ValueError (ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()). While it might be perverse to use random from stdlib on a numpy array, such code exists in the wild, such as in the test suite of scikit-learn which this change then breaks. Perhaps the test is better seq is None or len(seq) == 0, since that's what is actually needed for the next line about an empty sequence?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides improving the error message and using clear code instead of a comment, this makes shuffle(), sample(), and randrange() slightly faster.