bpo-31083: IDLE: Document TabPage(Frame) for configdialog#2965
Merged
Conversation
mlouielu
reviewed
Aug 1, 2017
| indent_title.pack(side=TOP, anchor=W, padx=5) | ||
| self.indent_scale.pack(side=TOP, padx=5, fill=X) | ||
|
|
||
| return frame |
Contributor
There was a problem hiding this comment.
Does this need to return self?
Member
There was a problem hiding this comment.
No, because calling a class returns a new instance. In this case, the instance, self, is a frame. Create_widgets is now called within init (and the None return ignored) instead of by ConfigDialog.
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Aug 1, 2017
…honGH-2965) Add template as comment. Update existing classes to match outline. Initial patch by Cheryl Sabella. (cherry picked from commit 6f446be)
terryjreedy
added a commit
that referenced
this pull request
Aug 1, 2017
Contributor
|
@csabella Forgot to ask you, you can setup your name in GitHub settings，then inside the Otherwise you name inside |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31083