Skip to content

bpo-30781: IDLE - Use ttk Notebook in ConfigDialog #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terryjreedy merged 6 commits into from
Jul 29, 2017
Merged

bpo-30781: IDLE - Use ttk Notebook in ConfigDialog #2938

terryjreedy merged 6 commits into from
Jul 29, 2017

Conversation

@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jul 28, 2017 •
edited by bedevere-bot
Loading

On Windows, the switch disables one click event generate.

https://bugs.python.org/issue30781

@csabella
Copy link
Contributor

csabella commented Jul 28, 2017 •
edited
Loading

Wow! I didn't expect a notebook! It looks good.

The initial font on highlight_sample isn't right, but it's wrong on my master too, not just this branch.

Edit: highlight_sample broke when set_samples was removed from the command. Before the change, setting one of the font variables must have triggered the event. set_samples would have been called and thus change the font on highlight_sample, but now it's not being called at that time. I think set_samples needs to be called explicitly at the end of load_font_cfg.

@terryjreedy
Copy link
Member Author

terryjreedy commented Jul 28, 2017

When load font config is called, there tracers are not attached, which should mean that this docstring comment -- ' Setting font variables calls set_samples (thrice).' - should be wrong. Try adding back self.set_samples() at the bottom of the method. (I think it may have been there and I removed it when we put the set_samples() call into the tracers.

The tracers are attached when the load tests are run. Unless and until we change the timing, those tests should detach at the top and re-attach at the end.

@terryjreedy terryjreedy merged commit b331f80 into python:master Jul 29, 2017
@terryjreedy terryjreedy deleted the notebook branch July 29, 2017 04:49
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jul 29, 2017
@terryjreedy
[3.6] bpo-30781: IDLE - Use ttk Notebook in ConfigDialog (pythonGH-2938)
bcb4114 
The notebook looks a bit better.  It will work better with separate page classes. Traversal of widgets by Tab works better.  Switching tabs with keys becomes possible.  The font sample box works better at large font sizes.

One of the two simulated click tests no longer works.  This will be investigated while fixing a bug with the widget itself.
(cherry picked from commit b331f80)
terryjreedy added a commit that referenced this pull request Jul 29, 2017
@terryjreedy
[3.6] bpo-30781: IDLE - Use ttk Notebook in ConfigDialog (GH-2938) (#…
8364fef 
…2944)

The notebook looks a bit better.  It will work better with separate page classes. Traversal of widgets by Tab works better.  Switching tabs with keys becomes possible.  The font sample box works better at large font sizes.

One of the two simulated click tests no longer works.  This will be investigated while fixing a bug with the widget itself.
(cherry picked from commit b331f80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@terryjreedy @csabella @the-knights-who-say-ni