Skip to content

bpo-45212: Fix dangling threads in skipped tests in test_socket #28361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
Sep 16, 2021
Merged

bpo-45212: Fix dangling threads in skipped tests in test_socket #28361

serhiy-storchaka merged 2 commits into from
Sep 16, 2021

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 15, 2021 •
edited by bedevere-bot
Loading

tearDown() is not called if setUp() raises an exception
(including SkipTest). addCleanup() should be used for guaranteed
execution of the cleanup code.

https://bugs.python.org/issue45212

@serhiy-storchaka
bpo-45212: Fix dangling threads in skipped tests in test_socket
a9906a2 
tearDown() is not called if setUp() raises an exception
(including SkipTest). addCleanup() should be used for guaranteed
execution of the cleanup code.
@serhiy-storchaka serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 16, 2021
@bedevere-bot
Copy link

bedevere-bot commented Sep 16, 2021

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 2a37255 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 16, 2021
@serhiy-storchaka serhiy-storchaka merged commit 7dacb70 into python:main Sep 16, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Sep 16, 2021

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test-socket-dangling-threads branch September 16, 2021 10:30
@miss-islington
Copy link
Contributor

miss-islington commented Sep 16, 2021

Sorry @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7dacb70485a0910eb298c24b4d051720ca56fb91 3.10

@bedevere-bot
Copy link

bedevere-bot commented Sep 16, 2021

GH-28384 is a backport of this pull request to the 3.9 branch.

@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.10 only security fixes label Sep 16, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2021
@serhiy-storchaka @miss-islington
bpo-45212: Fix dangling threads in skipped tests in test_socket (pyth…
f577355 
…onGH-28361)

tearDown() is not called if setUp() raises an exception
(including SkipTest). addCleanup() should be used for guaranteed
execution of the cleanup code.
(cherry picked from commit 7dacb70)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.10 only security fixes label Sep 16, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Sep 16, 2021

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 16, 2021
@bedevere-bot
Copy link

bedevere-bot commented Sep 16, 2021

GH-28385 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2021
@serhiy-storchaka @miss-islington
bpo-45212: Fix dangling threads in skipped tests in test_socket (pyth…
a937c7e 
…onGH-28361)

tearDown() is not called if setUp() raises an exception
(including SkipTest). addCleanup() should be used for guaranteed
execution of the cleanup code.
(cherry picked from commit 7dacb70)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Sep 17, 2021

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 17, 2021

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 17, 2021

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 17, 2021

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 17, 2021
@serhiy-storchaka
[3.9] bpo-45212: Fix dangling threads in skipped tests in test_socket (…
2b12289 
…pythonGH-28361)

tearDown() is not called if setUp() raises an exception
(including SkipTest). addCleanup() should be used for guaranteed
execution of the cleanup code.
(cherry picked from commit 7dacb70)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 17, 2021
Merged
@bedevere-bot
Copy link

bedevere-bot commented Sep 17, 2021

GH-28408 is a backport of this pull request to the 3.9 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 17, 2021
@serhiy-storchaka
[3.10] bpo-45212: Fix dangling threads in skipped tests in test_socket (
09abf41 
pythonGH-28361)

tearDown() is not called if setUp() raises an exception
(including SkipTest). addCleanup() should be used for guaranteed
execution of the cleanup code.
(cherry picked from commit 7dacb70)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 17, 2021
Merged
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 17, 2021
@bedevere-bot
Copy link

bedevere-bot commented Sep 17, 2021

GH-28409 is a backport of this pull request to the 3.10 branch.

serhiy-storchaka added a commit that referenced this pull request Sep 17, 2021
@serhiy-storchaka
[3.10] bpo-45212: Fix dangling threads in skipped tests in test_socket (
ce59ac9 
GH-28361) (GH-28409)

tearDown() is not called if setUp() raises an exception
(including SkipTest). addCleanup() should be used for guaranteed
execution of the cleanup code.
(cherry picked from commit 7dacb70)
serhiy-storchaka added a commit that referenced this pull request Sep 17, 2021
@serhiy-storchaka
[3.9] bpo-45212: Fix dangling threads in skipped tests in test_socket (…
10c3cf7 
…GH-28361) (GH-28408)

tearDown() is not called if setUp() raises an exception
(including SkipTest). addCleanup() should be used for guaranteed
execution of the cleanup code.
(cherry picked from commit 7dacb70)
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @bedevere-bot @miss-islington @the-knights-who-say-ni