bpo-45057: Simplify RegressionTestResult by serhiy-storchaka · Pull Request #28081 · python/cpython

serhiy-storchaka · 2021-08-31T07:27:47Z

Remove code which duplicates the functionality of TextTestResult.

https://bugs.python.org/issue45057

Remove code which duplicates the functionality of TextTestResult.

vstinner

LGTM. Yeah, it looks like most code already exists in Lib/unittest/runner.py.

I didn't check manually if the output remains the same.

vstinner · 2021-08-31T15:49:19Z

Lib/test/support/testresult.py

-    def printErrorList(self, flavor, errors):
-        for test, err in errors:
-            self.stream.write(self.separator1)
-            self.stream.write(f'{flavor}: {self.getDescription(test)}\n')


You can modernize printErrors() in Lib/unittest/runner.py. It contains very useless code like "%s" % err.

Maybe in other PR. This PR does not touch that file.

As you want, it was just a remark. I approved your PR (and you merged it ;-))

miss-islington · 2021-08-31T17:45:11Z

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington · 2021-08-31T17:45:21Z

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2b76a5322fdf71d62b531fd765085f96f981c244 3.9

bedevere-bot · 2021-08-31T17:45:22Z

GH-28101 is a backport of this pull request to the 3.10 branch.

Remove code which duplicates the functionality of TextTestResult. (cherry picked from commit 2b76a53) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Remove code which duplicates the functionality of TextTestResult.. (cherry picked from commit 2b76a53) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot · 2021-08-31T17:51:51Z

GH-28103 is a backport of this pull request to the 3.9 branch.

vstinner · 2021-08-31T21:17:58Z

For me this change is just refactoring and not bugfix, you can backport it, but usually I prefer to leave stable branches unchanged.

Remove code which duplicates the functionality of TextTestResult. (cherry picked from commit 2b76a53)

Remove code which duplicates the functionality of TextTestResult. (cherry picked from commit 2b76a53) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka · 2021-09-01T06:49:43Z

It is internal code, and it can help when backport changes to TextTestResult. I prefer to backport test changes.

bedevere-bot · 2021-09-01T07:42:32Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 macOS 3.10 has failed when building commit 3d56272.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/681/builds/345) and take a look at the build logs.
Check if the failure is related to this commit (3d56272) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/681/builds/345

Failed tests:

test_importlib

Failed subtests:

test_multiprocessing_pool_circular_import - test.test_importlib.test_threaded_import.ThreadedImportTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

408 tests OK.

10 slowest tests:

test_concurrent_futures: 3 min 51 sec
test_unparse: 3 min 20 sec
test_multiprocessing_spawn: 2 min 38 sec
test_tokenize: 2 min 22 sec
test_lib2to3: 2 min 1 sec
test_unicodedata: 1 min 50 sec
test_multiprocessing_forkserver: 1 min 48 sec
test_asyncio: 1 min 41 sec
test_capi: 1 min 36 sec
test_logging: 1 min 1 sec

1 test failed:
test_importlib

18 tests skipped:
test_devpoll test_epoll test_gdb test_ioctl test_msilib
test_multiprocessing_fork test_ossaudiodev test_smtpnet test_spwd
test_ssl test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 25 min 29 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/test_importlib/test_threaded_import.py", line 258, in test_multiprocessing_pool_circular_import
    script_helper.assert_python_ok(fn)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/support/script_helper.py", line 160, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/support/script_helper.py", line 145, in _assert_python
    res.fail(cmd_line)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/support/script_helper.py", line 72, in fail
    raise AssertionError("Process return code is %d\n"
AssertionError: Process return code is 1
command line: ['/Users/buildbot/buildarea/3.10.billenstein-macos/build/python.exe', '-X', 'faulthandler', '-I', '/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/test_importlib/partial/pool_in_threads.py']


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/test_importlib/partial/pool_in_threads.py", line 9, in t
    with multiprocessing.Pool(1):
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/context.py", line 119, in Pool
    return Pool(processes, initializer, initargs, maxtasksperchild,
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/pool.py", line 212, in __init__
    self._repopulate_pool()
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/pool.py", line 303, in _repopulate_pool
    return self._repopulate_pool_static(self._ctx, self.Process,
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/pool.py", line 326, in _repopulate_pool_static
    w.start()
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/process.py", line 121, in start
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/context.py", line 284, in _Popen
    return Popen(process_obj)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/popen_spawn_posix.py", line 32, in __init__
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/popen_fork.py", line 19, in __init__
    self._launch(process_obj)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/popen_spawn_posix.py", line 53, in _launch
OSError: [Errno 24] Too many open files
/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 120 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:237: UserWarning: resource_tracker: '/mp-klnfwvgv': [Errno 2] No such file or directory
  warnings.warn('resource_tracker: %r: %s' % (name, e))
/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:237: UserWarning: resource_tracker: '/mp-phgypx9f': [Errno 2] No such file or directory
  warnings.warn('resource_tracker: %r: %s' % (name, e))
---

vstinner · 2021-09-01T13:49:49Z

Hi! The buildbot x86-64 macOS 3.10 has failed when building commit 3d56272.

This is https://bugs.python.org/issue43592

bpo-45057: Simplify RegressionTestResult

a3e394c

Remove code which duplicates the functionality of TextTestResult.

serhiy-storchaka added tests Tests in the Lib/test dir needs backport to 3.9 needs backport to 3.10 only security fixes labels Aug 31, 2021

the-knights-who-say-ni added the CLA signed label Aug 31, 2021

bedevere-bot added the awaiting core review label Aug 31, 2021

serhiy-storchaka requested a review from zooba August 31, 2021 07:28

vstinner approved these changes Aug 31, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Aug 31, 2021

serhiy-storchaka added the skip news label Aug 31, 2021

serhiy-storchaka merged commit 2b76a53 into python:main Aug 31, 2021

bedevere-bot removed the awaiting merge label Aug 31, 2021

serhiy-storchaka deleted the regression-test-result branch August 31, 2021 17:45

miss-islington assigned serhiy-storchaka Aug 31, 2021

bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 31, 2021

bedevere-bot removed the needs backport to 3.9 label Aug 31, 2021

serhiy-storchaka added a commit that referenced this pull request Sep 1, 2021

[3.9] bpo-45057: Simplify RegressionTestResult (GH-28081) (GH-28103)

e527f79

Remove code which duplicates the functionality of TextTestResult. (cherry picked from commit 2b76a53)

serhiy-storchaka removed their assignment Jun 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bpo-45057: Simplify RegressionTestResult#28081

bpo-45057: Simplify RegressionTestResult#28081
serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka:regression-test-result

serhiy-storchaka commented Aug 31, 2021 •

edited by bedevere-bot

Loading

Uh oh!

vstinner left a comment

Uh oh!

vstinner Aug 31, 2021 •

edited

Loading

Uh oh!

serhiy-storchaka Aug 31, 2021

Uh oh!

vstinner Aug 31, 2021

Uh oh!

miss-islington commented Aug 31, 2021

Uh oh!

miss-islington commented Aug 31, 2021

Uh oh!

bedevere-bot commented Aug 31, 2021

Uh oh!

bedevere-bot commented Aug 31, 2021

Uh oh!

vstinner commented Aug 31, 2021

Uh oh!

serhiy-storchaka commented Sep 1, 2021

Uh oh!

bedevere-bot commented Sep 1, 2021

Uh oh!

vstinner commented Sep 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

serhiy-storchaka commented Aug 31, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner Aug 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Aug 31, 2021

Choose a reason for hiding this comment

Uh oh!

vstinner Aug 31, 2021

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Aug 31, 2021

Uh oh!

miss-islington commented Aug 31, 2021

Uh oh!

bedevere-bot commented Aug 31, 2021

Uh oh!

bedevere-bot commented Aug 31, 2021

Uh oh!

vstinner commented Aug 31, 2021

Uh oh!

serhiy-storchaka commented Sep 1, 2021

Uh oh!

bedevere-bot commented Sep 1, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

vstinner commented Sep 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

serhiy-storchaka commented Aug 31, 2021 •

edited by bedevere-bot

Loading

vstinner Aug 31, 2021 •

edited

Loading