Skip to content

bpo-44925: [docs] Confusing deprecation notice for typing.IO#28004

Merged
Fidget-Spinner merged 4 commits intopython:mainfrom
DonnaDia:fix-issue-44925
Aug 31, 2021
Merged

bpo-44925: [docs] Confusing deprecation notice for typing.IO#28004
Fidget-Spinner merged 4 commits intopython:mainfrom
DonnaDia:fix-issue-44925

Conversation

@DonnaDia
Copy link
Copy Markdown
Contributor

@DonnaDia DonnaDia commented Aug 27, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Aug 27, 2021
gvanrossum
gvanrossum reviewed Aug 27, 2021
View reviewed changes
@Fidget-Spinner
Copy link
Copy Markdown
Member

Fidget-Spinner commented Aug 28, 2021

There's also the label for typing.re that needs fixing at https://github.com/python/cpython/pull/28004/files#diff-8a0f115fde6769c122b771b6d0eca184c4580f7b5fabe2f0b0579c679424364fR1522 .

@DonnaDia DonnaDia requested a review from gvanrossum August 28, 2021 04:57
Fidget-Spinner
Fidget-Spinner requested changes Aug 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonnaDia sorry if my previous message wasn't clear, but there's another instance of the same deprecation notice below at line 1523 (for typing.Pattern and typing.Match). Please apply the same changes you did for the current typing.IO deprecation notice. Thank you.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 28, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@DonnaDia
Copy link
Copy Markdown
Contributor Author

DonnaDia commented Aug 28, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 28, 2021

Thanks for making the requested changes!

@Fidget-Spinner: please review the changes made to this pull request.

Fidget-Spinner
Fidget-Spinner approved these changes Aug 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Fidget-Spinner Fidget-Spinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM.

@Fidget-Spinner Fidget-Spinner merged commit edae42f into python:main Aug 31, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 31, 2021

Thanks @DonnaDia for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 31, 2021
@DonnaDia @miss-islington
bpo-44925: [docs] Fix confusing deprecation notice for typing.IO (pyt…
77ac62f 
…honGH-28004)

(cherry picked from commit edae42f)

Co-authored-by: DonnaDia <37962843+DonnaDia@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 31, 2021

GH-28084 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 31, 2021
@Fidget-Spinner
Copy link
Copy Markdown
Member

Fidget-Spinner commented Aug 31, 2021

@gvanrossum or @srittau, if either of you are unsatisfied, please don't hesitate to reopen the issue or comment on this PR.

@DonnaDia congrats on your first commit to CPython 🥳 !!

miss-islington added a commit that referenced this pull request Aug 31, 2021
@miss-islington @DonnaDia
bpo-44925: [docs] Fix confusing deprecation notice for typing.IO (GH-…
1d0c559 
…28004)

(cherry picked from commit edae42f)

Co-authored-by: DonnaDia <37962843+DonnaDia@users.noreply.github.com>
@DonnaDia DonnaDia deleted the fix-issue-44925 branch August 31, 2021 10:37
@DonnaDia DonnaDia restored the fix-issue-44925 branch August 31, 2021 10:39
@srittau
Copy link
Copy Markdown
Contributor

srittau commented Aug 31, 2021

Looks good to me.

@DonnaDia DonnaDia deleted the fix-issue-44925 branch August 31, 2021 11:16
@rittneje rittneje mentioned this pull request Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@DonnaDia @Fidget-Spinner @bedevere-bot @miss-islington @srittau @gvanrossum @the-knights-who-say-ni