Skip to content

bpo-30978: str.format_map() now passes key lookup exceptions through.#2790

Merged
serhiy-storchaka merged 6 commits into
python:masterfrom
serhiy-storchaka:str-format_map-lookup-exceptions
Aug 3, 2017
Merged

bpo-30978: str.format_map() now passes key lookup exceptions through.#2790
serhiy-storchaka merged 6 commits into
python:masterfrom
serhiy-storchaka:str-format_map-lookup-exceptions

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 21, 2017

Copy link
Copy Markdown
Member

No description provided.

@serhiy-storchaka serhiy-storchaka added needs backport to 2.7 type-bug An unexpected behavior, bug, or error labels Jul 21, 2017
@mention-bot

mention-bot commented Jul 21, 2017

Copy link
Copy Markdown

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericvsmith, @pitrou and @doerwalter to be potential reviewers.

@vstinner

vstinner commented Jul 21, 2017

Copy link
Copy Markdown
Member

A test fails:

ERROR: test_match_getitem (test.test_re.ReTests)

Traceback (most recent call last):

File "/home/travis/build/python/cpython/Lib/test/test_re.py", line 472, in test_match_getitem

'a1={a2}'.format_map(m)

IndexError: no such group

You should document this behaviour change in the NEWS entry (and fix the test).

@ericvsmith

ericvsmith commented Jul 21, 2017

Copy link
Copy Markdown
Member

Other than the failing test in test_re, this looks good to me.

vstinner
vstinner approved these changes Jul 21, 2017
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's now better with NEWS describing the old behaviour ;-)

ericvsmith
ericvsmith reviewed Jul 21, 2017
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2017-07-21-07-39-05.bpo-30978.f0jODc.rst Outdated
@@ -1 +1,2 @@
str.format_map() now passes key lookup exceptions through.
Previousle any exception was replaced with a KeyError exception.

@ericvsmith ericvsmith Jul 21, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Previousle -> Previously

@serhiy-storchaka serhiy-storchaka Jul 21, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@serhiy-storchaka serhiy-storchaka merged commit 5075416 into python:master Aug 3, 2017
@serhiy-storchaka serhiy-storchaka deleted the str-format_map-lookup-exceptions branch August 3, 2017 08:45
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 3, 2017
@serhiy-storchaka
[3.6] bpo-30978: str.format_map() now passes key lookup exceptions th…
5fbea8e 
…rough. (pythonGH-2790)

Previously any exception was replaced with a KeyError exception.
(cherry picked from commit 5075416)
@bedevere-bot

bedevere-bot commented Aug 3, 2017

Copy link
Copy Markdown

GH-2992 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka added a commit that referenced this pull request Aug 3, 2017
@serhiy-storchaka
[3.6] bpo-30978: str.format_map() now passes key lookup exceptions th…
f08b2be 
…rough. (GH-2790) (#2992)

Previously any exception was replaced with a KeyError exception.
(cherry picked from commit 5075416)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith left review comments

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger rhettinger approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@serhiy-storchaka @mention-bot @vstinner @ericvsmith @bedevere-bot @rhettinger @the-knights-who-say-ni