bpo-25008: Deprecate smtpd and point to aiosmtpd#274
Merged
vstinner merged 2 commits intopython:masterfrom Feb 24, 2017
Merged
Conversation
vstinner
reviewed
Feb 24, 2017
Doc/library/smtpd.rst
Outdated
|
|
||
| .. seealso:: | ||
|
|
||
| The `aiosmtpd <http://aiosmtpd.readthedocs.io/en/latest/>`_ package is a |
Member
There was a problem hiding this comment.
I suggest to drop the /en/latest/ part of the URL.
vstinner
approved these changes
Feb 24, 2017
Member
|
Yeah, it's time to say goodbye to asyncore :-( |
Member
|
Hm... we don't have @Haypo I created an issue about replacing asyncore a while back: http://bugs.python.org/issue28533 |
Member
Author
|
I guess I'll do the cherry picks. I think they all need merge requests right? |
Member
|
warsaw
added a commit
to warsaw/cpython
that referenced
this pull request
Feb 24, 2017
warsaw
added a commit
to warsaw/cpython
that referenced
this pull request
Feb 24, 2017
warsaw
added a commit
to warsaw/cpython
that referenced
this pull request
Feb 24, 2017
Member
Author
|
@Mariatta It also looks like 3.4 is not a protected branch. I think I can self-approve merges to that branch. |
Member
Author
|
Or maybe @dstufft was quicker than my browser. :) |
warsaw
added a commit
that referenced
this pull request
Feb 24, 2017
warsaw
added a commit
that referenced
this pull request
Feb 24, 2017
warsaw
added a commit
that referenced
this pull request
Feb 24, 2017
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
Fix ResourceWarning due to unclosed file resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should probably also cherry pick this change into 3.4, 3.5, and 3.6 since those are the versions aiosmtpd are compatible with.