Skip to content

[3.10] bpo-42161: mathmodule.c: move _PyLong_GetOne() loop invariant (GH-26391) #26393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
May 26, 2021
Merged

[3.10] bpo-42161: mathmodule.c: move _PyLong_GetOne() loop invariant (GH-26391) #26393

vstinner merged 1 commit into from
May 26, 2021

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 26, 2021 •
edited by bedevere-bot
Loading

Move _PyLong_GetZero() and _PyLong_GetOne() loop invariants outside
loops in functions:

  • math.comb()
  • math.gcd()
  • math.lcm()
  • math.perm()
    (cherry picked from commit 3e7ee02)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue42161

@vstinner @miss-islington
bpo-42161: mathmodule.c: move _PyLong_GetOne() loop invariant (python…
7edc52a 
…GH-26391)

Move _PyLong_GetZero() and _PyLong_GetOne() loop invariants outside
loops in functions:

* math.comb()
* math.gcd()
* math.lcm()
* math.perm()
(cherry picked from commit 3e7ee02)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Contributor Author

miss-islington commented May 26, 2021

@vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 26, 2021
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented May 26, 2021

@vstinner: Status check is done, and it's a success ✅ .

vstinner
vstinner approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner vstinner merged commit 4115996 into python:3.10 May 26, 2021
@miss-islington miss-islington deleted the backport-3e7ee02-3.10 branch May 26, 2021 23:13
@miss-islington
Copy link
Contributor Author

miss-islington commented May 26, 2021

@vstinner: Status check is done, and it's a success ❌ .

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot