Skip to content

bpo-44156: Make cached string constants in compile.c subinterpreter compatible #26161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 4 commits into from
May 25, 2021
Merged

bpo-44156: Make cached string constants in compile.c subinterpreter compatible #26161

vstinner merged 4 commits into from
May 25, 2021

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented May 16, 2021 •
edited
Loading

@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented May 16, 2021

@vstinner, please take a look if you have the time. Thank you!

@Fidget-Spinner Fidget-Spinner requested a review from vstinner May 16, 2021 12:40
@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented May 16, 2021

Some tests are failing because of GH action outages https://www.githubstatus.com/incidents/zbpwygxwb3gw.

@vstinner
Copy link
Member

vstinner commented May 17, 2021

Please create an issue for this change. You can a "meta" issue to make modules static variables compatible with sub-interpreters, but it's better to create a specific issue. For example, only replace "string constants".

See for example https://bugs.python.org/issue40521 but please don't reuse this one.

@Fidget-Spinner Fidget-Spinner changed the title bpo-42834: Make cached string constants in compile.c subinterpreter compatible bpo-44156: Make cached string constants in compile.c subinterpreter compatible May 17, 2021
@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented May 17, 2021

Please create an issue for this change. You can a "meta" issue to make modules static variables compatible with sub-interpreters, but it's better to create a specific issue. For example, only replace "string constants".

See for example https://bugs.python.org/issue40521 but please don't reuse this one.

Thanks Victor. I've followed your recommendations.

@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented May 17, 2021

I just noticed I need to regenerate the blurb. I'll do that soon.

vstinner
vstinner reviewed May 25, 2021
View reviewed changes
@vstinner vstinner merged commit 2966924 into python:main May 25, 2021
@vstinner
Copy link
Member

vstinner commented May 25, 2021

Merged, thanks.

@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented May 25, 2021

@vstinner Thank you for taking the time to review this and make the code more readable. I appreciate it :).

@Fidget-Spinner Fidget-Spinner deleted the compile-no-static-strings branch May 25, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Fidget-Spinner @vstinner @the-knights-who-say-ni @bedevere-bot