Skip to content

bpo-43466: Link with libz in PY_UNSUPPORTED_OPENSSL_BUILD path (GH-25587) #25587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiran merged 1 commit into from
Apr 26, 2021
Merged

bpo-43466: Link with libz in PY_UNSUPPORTED_OPENSSL_BUILD path (GH-25587) #25587

tiran merged 1 commit into from
Apr 26, 2021

Conversation

@tiran
Copy link
Member

@tiran tiran commented Apr 25, 2021 •
edited by bedevere-bot
Loading

Some OpenSSL build flavors need libz for compression support.

https://bugs.python.org/issue43466

@tiran
bpo-43466: Link with libz in PY_UNSUPPORTED_OPENSSL_BUILD path
51f42fd 
Some OpenSSL build flavors need libz for compression support.
@tiran tiran mentioned this pull request Apr 25, 2021
Closed
@pablogsal
Copy link
Member

pablogsal commented Apr 26, 2021 •
edited
Loading

Ok, tested in RHEL 6 compiled against OpenSSL 1.1.1k:

cat /etc/redhat-release
Red Hat Enterprise Linux Server release 6.8 (Santiago)
$ ldd cpython/build/lib.linux-x86_64-3.10/_ssl.cpython-310-x86_64-linux-gnu.so
        linux-vdso.so.1 =>  (0x00007ffed2d5d000)
        libz.so.1 => /lib64/libz.so.1 (0x00007fcfe8028000)
        libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fcfe7df0000)
        libc.so.6 => /lib64/libc.so.6 (0x00007fcfe7a5c000)
        /lib64/ld-linux-x86-64.so.2 (0x0000003dcb800000)


$ objdump -T cpython/build/lib.linux-x86_64-3.10/_ssl.cpython-310-x86_64-linux-gnu.so  | grep ssl
cpython/build/lib.linux-x86_64-3.10/_ssl.cpython-310-x86_64-linux-gnu.so:     file format elf64-x86-64
000000000005e2c0 g    DF .text  000000000000000c  Base        PyInit__ssl


./python -m test test_ssl test_hashlib
0:00:00 load avg: 0.74 Run tests sequentially
0:00:00 load avg: 0.74 [1/2] test_ssl
0:00:04 load avg: 0.76 [2/2] test_hashlib

== Tests result: SUCCESS ==

All 2 tests OK.

Total duration: 5.4 sec
Tests result: SUCCESS

@pablogsal
Copy link
Member

pablogsal commented Apr 26, 2021

@tiran should i test any other thing apart from test_ssl and test_hashlib?

@tiran
Copy link
Member Author

tiran commented Apr 26, 2021

Thanks Pablo!

The zlib issue should only affect OpenSSL builds with enable-zlib-dynamic. Standard builds no longer use zlib. Builds with `enable-zlib`` should have libz embedded.

@tiran
Copy link
Member Author

tiran commented Apr 26, 2021

./python Lib/test/ssltests.py executes tests modules that use ssl or hashlib.

@pablogsal
Copy link
Member

pablogsal commented Apr 26, 2021

LGTM

Land it when you have some time :)

@tiran tiran changed the title bpo-43466: Link with libz in PY_UNSUPPORTED_OPENSSL_BUILD path bpo-43466: Link with libz in PY_UNSUPPORTED_OPENSSL_BUILD path (GH-25587) Apr 26, 2021
@tiran tiran merged commit 5f87915 into python:master Apr 26, 2021
@tiran tiran deleted the bpo-43466-libz branch April 26, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran @pablogsal @the-knights-who-say-ni @bedevere-bot