bpo-23835: Enforce that configparser defaults are strings #2558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambv
requested changes
Jul 12, 2017
Contributor
ambv
left a comment
There was a problem hiding this comment.
Instead of this, reading defaults should be done by callingself.read_dict(), then it will behave consistently with doing:
cp['DEFAULT'] = {1: 2.4}
Contributor
Author
|
Yeah, that seems more sensible (I originally wrote the patch against 2.7, which is why I didn't use read_dict). Do you want the new version in a new PR, or just replace the current PR with the new code? Also, where should I add a test, I couldn't find where I should add it last time I looked. |
Contributor
|
Replacing the current PR is totally fine. There are tests for configparser in Lib/test/test_configparser.py. |
Contributor
Author
|
Done. |
Contributor
Author
|
Ping? |
Add assert statements to the new test.
Contributor
|
I'll add a NEWS.d entry in a separate PR. |
Contributor
|
Thanks! ✨ 🍰 ✨ |
GadgetSteve
pushed a commit
to GadgetSteve/cpython
that referenced
this pull request
Sep 10, 2017
* Enforce that configparser defaults are strings * Update test_configparser.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the patch attached to https://bugs.python.org/issue23835, updated to master.
https://bugs.python.org/issue23835