Skip to content

bpo-43779: _PyArena_AddPyObject only steals a ref on success #25289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
Apr 8, 2021
Merged

bpo-43779: _PyArena_AddPyObject only steals a ref on success #25289

pablogsal merged 1 commit into from
Apr 8, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 8, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 8, 2021

skip news

@pablogsal pablogsal merged commit c0e11a3 into python:master Apr 8, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Apr 8, 2021

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 8, 2021

Sorry, @erlend-aasland and @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c0e11a3ceb9427e09db4224f394c7789bf6deec5 3.9

@pablogsal
Copy link
Member

pablogsal commented Apr 8, 2021

@erlend-aasland Could you do the manual backport?

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 8, 2021

@erlend-aasland Could you do the manual backport?

Sure!

@erlend-aasland erlend-aasland deleted the fix-pyarena-addpyobject-refleaks branch April 8, 2021 23:20
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Apr 8, 2021
[3.9] Fix possible refleak involving _PyArena_AddPyObject (pythonGH-2…
7430f23 
…5289).

(cherry picked from commit c0e11a3)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

bedevere-bot commented Apr 8, 2021

GH-25294 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit that referenced this pull request Apr 9, 2021
@pablogsal
[3.9] bpo-43779: Fix possible refleak involving _PyArena_AddPyObject (G…
76d270e 
…H-25289). (GH-25294)

* [3.9] Fix possible refleak involving _PyArena_AddPyObject (GH-25289).
(cherry picked from commit c0e11a3)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

* Update Parser/pegen/pegen.c

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @miss-islington @pablogsal @bedevere-bot @the-knights-who-say-ni