Skip to content

[3.8] bpo-43075: Fix ReDoS in urllib AbstractBasicAuthHandler (GH-24391)#25248

Merged
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-7215d1a-3.8
Apr 7, 2021
Merged

[3.8] bpo-43075: Fix ReDoS in urllib AbstractBasicAuthHandler (GH-24391)#25248
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-7215d1a-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 7, 2021

Copy link
Copy Markdown
Contributor

Fix Regular Expression Denial of Service (ReDoS) vulnerability in
urllib.request.AbstractBasicAuthHandler. The ReDoS-vulnerable regex
has quadratic worst-case complexity and it allows cause a denial of
service when identifying crafted invalid RFCs. This ReDoS issue is on
the client side and needs remote attackers to control the HTTP server.
(cherry picked from commit 7215d1a)

Co-authored-by: Yeting Li liyt@ios.ac.cn

https://bugs.python.org/issue43075

Fix Regular Expression Denial of Service (ReDoS) vulnerability in
urllib.request.AbstractBasicAuthHandler. The ReDoS-vulnerable regex
has quadratic worst-case complexity and it allows cause a denial of
service when identifying crafted invalid RFCs. This ReDoS issue is on
the client side and needs remote attackers to control the HTTP server.
(cherry picked from commit 7215d1a)

Co-authored-by: Yeting Li <liyt@ios.ac.cn>
@miss-islington

Copy link
Copy Markdown
Contributor Author

@yetingli and @vstinner: Status check is done, and it's a success ✅ .

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@yetingli and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit e7654b6 into python:3.8 Apr 7, 2021
@miss-islington miss-islington deleted the backport-7215d1a-3.8 branch April 7, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants