Skip to content

bpo-30805: Avoid race condition of self._debug in event loop#2490

Closed
william-gr wants to merge 1 commit into
python:masterfrom
william-gr:issue/race_debug_loop
Closed

bpo-30805: Avoid race condition of self._debug in event loop#2490
william-gr wants to merge 1 commit into
python:masterfrom
william-gr:issue/race_debug_loop

Conversation

@william-gr

Copy link
Copy Markdown

If a process is schedule to run in the event loop with debug disabled
and debug is then enabled before the process finishes it will result in
a traceback: log_debug undefined.

If a process is schedule to run in the event loop with debug disabled
and debug is then enabled before the process finishes it will result in
a traceback: log_debug undefined.
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@william-gr william-gr changed the title Avoid race condition of self._debug in event loop bpo-30805: Avoid race condition of self._debug in event loop Jun 29, 2017
@william-gr

Copy link
Copy Markdown
Author

CLA signed. I dont know how to update that tag.

Just prod the bot @the-knights-who-say-ni ?

@methane methane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ned-deily ned-deily requested review from 1st1 and asvetlov June 8, 2018 20:33
1st1 pushed a commit to 1st1/cpython that referenced this pull request Jun 8, 2018
@1st1

1st1 commented Jun 8, 2018

Copy link
Copy Markdown
Member

Closing this PR in favour of #7545 as we don't have time to iterate on this patch before 3.7.0rc1.

@1st1 1st1 closed this Jun 8, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2018
Supersedes python#2490
(cherry picked from commit 12f482e)

Co-authored-by: Yury Selivanov <yury@magic.io>
1st1 pushed a commit that referenced this pull request Jun 8, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2018
Supersedes python#2490
(cherry picked from commit 12f482e)

Co-authored-by: Yury Selivanov <yury@magic.io>
miss-islington added a commit that referenced this pull request Jun 8, 2018
Supersedes #2490
(cherry picked from commit 12f482e)

Co-authored-by: Yury Selivanov <yury@magic.io>
miss-islington added a commit that referenced this pull request Jun 8, 2018
Supersedes #2490
(cherry picked from commit 12f482e)

Co-authored-by: Yury Selivanov <yury@magic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants