Skip to content

bpo-43439: Add audit hooks for gc functions #24794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 2 commits into from
Mar 10, 2021
Merged

bpo-43439: Add audit hooks for gc functions #24794

pablogsal merged 2 commits into from
Mar 10, 2021

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 8, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested review from vstinner and zooba March 8, 2021 23:06
vstinner
vstinner reviewed Mar 8, 2021
View reviewed changes
vstinner
vstinner reviewed Mar 8, 2021
View reviewed changes
zooba
zooba approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, either with or without Victor's suggestions.

This can be backported, btw. New audit events are allowed to be added in earlier releases.

vstinner
vstinner approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update!

Note: I don't know the format of the "audit-event::" markup in the doc, so I didn't check it.

@pablogsal pablogsal merged commit b4f9089 into python:master Mar 10, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Mar 10, 2021

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@pablogsal
Copy link
Member Author

pablogsal commented Mar 10, 2021

Thanks for the review!

@miss-islington
Copy link
Contributor

miss-islington commented Mar 10, 2021

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b4f9089d4aa787c5b74134c98e5f0f11d9e63095 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Mar 10, 2021

Sorry @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b4f9089d4aa787c5b74134c98e5f0f11d9e63095 3.8

pablogsal added a commit to pablogsal/cpython that referenced this pull request Mar 10, 2021
@pablogsal
[3.8] bpo-43439: Add audit hooks for gc functions (pythonGH-24794).
40da548 
(cherry picked from commit b4f9089)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 10, 2021

GH-24810 is a backport of this pull request to the 3.8 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Mar 10, 2021
@pablogsal
[3.9] bpo-43439: Add audit hooks for gc functions (pythonGH-24794).
41f3498 
(cherry picked from commit b4f9089)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 10, 2021

GH-24811 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit that referenced this pull request Mar 10, 2021
@pablogsal
[3.9] bpo-43439: Add audit hooks for gc functions (GH-24794). (GH-24811)
f814675 
(cherry picked from commit b4f9089)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington pushed a commit that referenced this pull request Mar 10, 2021
@pablogsal
[3.8] bpo-43439: Add audit hooks for gc functions (GH-24794). (GH-24810)
a6d0182 
(cherry picked from commit b4f9089)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal pablogsal deleted the bpo-43439 branch May 19, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@zooba zooba zooba approved these changes

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @miss-islington @bedevere-bot @vstinner @zooba @the-knights-who-say-ni