[3.9] bpo-43406: Fix possible race condition where PyErr_CheckSignals tries to execute a non-Python signal handler (GH-24756)
#24761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries to execute a non-Python signal handler (pythonGH-24756) We can receive signals (at the C level, in `trip_signal()` in signalmodule.c) while `signal.signal` is being called to modify the corresponding handler. Later when `PyErr_CheckSignals()` is called to handle the given signal, the handler may be a non-callable object and would raise a cryptic asynchronous exception. (cherry picked from commit 68245b7) Co-authored-by: Antoine Pitrou <antoine@python.org>
Contributor
Author
|
@pitrou: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@pitrou: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@pitrou: Status check is done, and it's a success ✅ . |
Member
|
@pablogsal Is this backport ok to you? |
Contributor
Author
|
@pitrou: Status check is done, and it's a success ✅ . |
Contributor
Author
|
Sorry, I can't merge this PR. Reason: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can receive signals (at the C level, in
trip_signal()in signalmodule.c) whilesignal.signalis being called to modify the corresponding handler. Later whenPyErr_CheckSignals()is called to handle the given signal, the handler may be a non-callable object and would raise a cryptic asynchronous exception.(cherry picked from commit 68245b7)
Co-authored-by: Antoine Pitrou antoine@python.org
https://bugs.python.org/issue43406
Automerge-Triggered-By: GH:pitrou