[WIP/RFC] bpo-15872: tests: remove oddity from test_rmtree_errors#22967
Merged
miss-islington merged 1 commit intopython:masterfrom Dec 21, 2020
Merged
[WIP/RFC] bpo-15872: tests: remove oddity from test_rmtree_errors#22967miss-islington merged 1 commit intopython:masterfrom
miss-islington merged 1 commit intopython:masterfrom
Conversation
This was added for (some) Windows buildbots back in 2012, and should either not be necessary anymore, or it should probably get investigated why "\*.*" gets added to filenames in the first place. Ref: https://bugs.python.org/issue15872
3a33d80 to
366c8d5
Compare
blueyed
referenced
this pull request
Oct 26, 2020
The Windows buildbots seem to be unable to agree whether they need them or not.
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Contributor
Author
|
I think this is still legit. |
Member
|
I mean if it's passing now on all bots, I guess that construct not necessary anymore? You'll need to apply skip news it seems tho? |
Contributor
Author
Yes, that's what I'm thinking also.
I cannot. |
hynek
approved these changes
Dec 21, 2020
Member
|
Thanks for wading through these old cobwebs! |
|
Member
|
That looks very unrelated, so ignoring. |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…thonGH-22967) This was added for (some) Windows buildbots back in 2012, and should either not be necessary anymore, or it should probably get investigated why "\*.*" gets added to filenames in the first place. Ref: Automerge-Triggered-By: GH:hynek
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added for (some) Windows buildbots back in 2012, and should
either not be necessary anymore, or it should probably get investigated
why "*.*" gets added to filenames in the first place.
Ref: https://bugs.python.org/issue15872
https://bugs.python.org/issue15872
Automerge-Triggered-By: GH:hynek