bpo-30645: use an internal variable while iterating in imp.load_package()#2268
Merged
brettcannon merged 3 commits intopython:masterfrom Jun 23, 2017
commodo:fix-imp-loop
Merged
bpo-30645: use an internal variable while iterating in imp.load_package()#2268brettcannon merged 3 commits intopython:masterfrom commodo:fix-imp-loop
brettcannon merged 3 commits intopython:masterfrom
commodo:fix-imp-loop
Conversation
|
@commodo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @ericsnowcurrently and @ncoghlan to be potential reviewers. |
methane
approved these changes
Jun 19, 2017
Member
|
@commodo Did you want to add yourself to the ACKS file and write an entry for Misc/NEWS (somewhere not at the top of the Library section to avoid merge conflicts)? |
Contributor
Author
|
ack thanks :) |
methane
reviewed
Jun 20, 2017
Misc/NEWS
Outdated
Member
There was a problem hiding this comment.
"use an internal variable" is implementation detail and it's not suitable for NEWS entry.
Please describe the bug you fixed.
Contributor
Author
|
ack |
…ge() The imp.load_package() function is marked as deprecated, however, some packages (like virtualenv) seem to use it. The problem with that loop, is that if the .py file does not exist, you'll get a `<path-to-package>__init__.py/__init__.pyc` file. When shipping only Python bytecodes, we don't want that. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
brettcannon
approved these changes
Jun 23, 2017
Member
brettcannon
left a comment
There was a problem hiding this comment.
I'm not worrying about tests since the problem is very obvious and this whole module is actually deprecated.
brettcannon
pushed a commit
to brettcannon/cpython
that referenced
this pull request
Jun 23, 2017
…ythonGH-2268) Bug didn't manifest itself when importing a module with source as .py files are always the first on the search path. The issue only showed up in bytecode-only packages where the calculated file path would be ``__init__.py/__init__.pyc``. Patch by Alexandru Ardelean. (cherry picked from commit c38e32a)
brettcannon
added a commit
to brettcannon/cpython
that referenced
this pull request
Jun 23, 2017
…ge() (pythonGH-2268) Bug didn't manifest itself when importing a module with source as .py files are always the first on the search path. The issue only showed up in bytecode-only packages where the calculated file path would be ``__init__.py/__init__.pyc``. Patch by Alexandru Ardelean.. (cherry picked from commit c38e32a)
|
GH-2364 is a backport of this pull request to the 3.6 branch. |
brettcannon
pushed a commit
to brettcannon/cpython
that referenced
this pull request
Jun 23, 2017
…ge() (pythonGH-2268) Bug didn't manifest itself when importing a module with source as .py files are always the first on the search path. The issue only showed up in bytecode-only packages where the calculated file path would be ``__init__.py/__init__.pyc``. Patch by Alexandru Ardelean.. (cherry picked from commit c38e32a)
|
GH-2365 is a backport of this pull request to the 3.5 branch. |
Member
|
Thanks for the PR, @commodo ! |
brettcannon
added a commit
that referenced
this pull request
Jun 23, 2017
…ge() (GH-2268) (#2364) Bug didn't manifest itself when importing a module with source as .py files are always the first on the search path. The issue only showed up in bytecode-only packages where the calculated file path would be ``__init__.py/__init__.pyc``. Patch by Alexandru Ardelean. (cherry picked from commit c38e32a)
brettcannon
added a commit
that referenced
this pull request
Jun 23, 2017
…ge() (GH-2268) (GH-2365) Bug didn't manifest itself when importing a module with source as .py files are always the first on the search path. The issue only showed up in bytecode-only packages where the calculated file path would be ``__init__.py/__init__.pyc``. Patch by Alexandru Ardelean. (cherry picked from commit c38e32a)
Contributor
Author
|
thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The imp.load_package() function is marked as deprecated,
however, some packages (like virtualenv) seem to use it.
The problem with that loop, is that if the .py file
does not exist, you'll get a
<path-to-package>__init__.py/__init__.pycfile.When shipping only Python bytecodes, we don't want that.
Signed-off-by: Alexandru Ardelean ardeleanalex@gmail.com