bpo-29755: Fixed the lgettext() family of functions in the gettext module.#2266
bpo-29755: Fixed the lgettext() family of functions in the gettext module.#2266serhiy-storchaka merged 4 commits intopython:masterfrom
Conversation
…dule. They now always return bytes.
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @warsaw and @loewis to be potential reviewers. |
|
LGTM, and thanks for submitting this! Some thoughts:
|
warsaw
left a comment
There was a problem hiding this comment.
A couple of additional suggestions were given, but I know you'll DTRT and what you have is already good, so I'll approve it in advance.
|
I'm interesting in your suggestions. In any case I'm going to rewrite the docs (group the |
|
Grouping the l* methods sounds like a great idea. I'd probably just put a reST admonition at the top of that section. Draft text: |
|
Thank you for your review @warsaw. Please look at the updated documentation since I'm not sure about my English. |
|
Looks great, thanks! |
…ext module. (pythonGH-2266) They now always return bytes. Updated the gettext documentation.. (cherry picked from commit 26cb465)
|
GH-2297 is a backport of this pull request to the 3.6 branch. |
…ext module. (pythonGH-2266) They now always return bytes. Updated the gettext documentation. (cherry picked from commit 26cb465)
|
GH-2298 is a backport of this pull request to the 3.5 branch. |
They now always return bytes.