Skip to content

bpo-41192: Fix some broken anchors for audit events#21310

Merged
akuchling merged 1 commit into
python:masterfrom
gousaiyang:bpo-41192-fix-anchors
Oct 19, 2020
Merged

bpo-41192: Fix some broken anchors for audit events#21310
akuchling merged 1 commit into
python:masterfrom
gousaiyang:bpo-41192-fix-anchors

Conversation

@gousaiyang

@gousaiyang gousaiyang commented Jul 4, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Fix broken anchors for cpython.run_startup, ctypes.call_function and poplib.putline audit events.

https://bugs.python.org/issue41192

@gousaiyang gousaiyang requested a review from a team as a code owner July 4, 2020 02:04
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 4, 2020
akuchling
akuchling approved these changes Oct 19, 2020
View reviewed changes

@akuchling akuchling left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks fine to me. I verified that the anchors were initially broken, and are fixed after the patch is applied.

@akuchling akuchling self-assigned this Oct 19, 2020
@akuchling akuchling merged commit ebc8c38 into python:master Oct 19, 2020
@bedevere-bot

bedevere-bot commented Oct 19, 2020

Copy link
Copy Markdown

@akuchling: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

Thanks @gousaiyang for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
@gousaiyang @miss-islington
bpo-41192: Fix some broken anchors for audit event entries (pythonGH-…
53a2749 
…21310)

(cherry picked from commit ebc8c38)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
@bedevere-bot

bedevere-bot commented Oct 19, 2020

Copy link
Copy Markdown

GH-22767 is a backport of this pull request to the 3.9 branch.

akuchling pushed a commit that referenced this pull request Oct 19, 2020
@miss-islington @gousaiyang
bpo-41192: Fix some broken anchors for audit event entries (GH-21310) (…
2ee6ef9 
…GH-22767)

(cherry picked from commit ebc8c38)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
@gousaiyang gousaiyang deleted the bpo-41192-fix-anchors branch October 19, 2020 16:35
@gousaiyang

gousaiyang commented Oct 19, 2020

Copy link
Copy Markdown
Contributor Author

Should we also backport this to 3.8? Since all the audit events related to this patch were introduced in 3.8 (see this audit events table which contains links with previously broken anchors).

@miss-islington

miss-islington commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

Thanks @gousaiyang for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Oct 19, 2020

Copy link
Copy Markdown

GH-22770 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
@gousaiyang @miss-islington
bpo-41192: Fix some broken anchors for audit event entries (pythonGH-…
83493b3 
…21310)

(cherry picked from commit ebc8c38)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
akuchling pushed a commit that referenced this pull request Oct 19, 2020
@miss-islington @gousaiyang
bpo-41192: Fix some broken anchors for audit event entries (GH-21310) (…
ec18c46 
…GH-22770)

(cherry picked from commit ebc8c38)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@gousaiyang @adorilson
bpo-41192: Fix some broken anchors for audit event entries (python#21310
1c0fc50 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@akuchling akuchling akuchling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@akuchling akuchling

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gousaiyang @bedevere-bot @miss-islington @akuchling @tirkarthi @the-knights-who-say-ni