bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags #21021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I've done manual backports -- should I keep the "needs backport to XXX" labels or ditch them? |
Member
Let's remove them, because if not the bots will create PRs on merge |
vstinner
reviewed
Jun 21, 2020
| @@ -0,0 +1,3 @@ | |||
| Stefan Behnel reported that cf_feature_version is used even when | |||
| PyCF_ONLY_AST is not set. This is against the intention and against the | |||
| documented behavior, so I fixed it. | |||
Member
There was a problem hiding this comment.
is it possible to avoid "I" in the NEWS entry? At least, replace it with Guido. Otherwise, it's unclear who is "I".
Member
Author
There was a problem hiding this comment.
I'll change this to "so it's been fixed."
pablogsal
approved these changes
Jun 28, 2020
|
@gvanrossum: Please replace |
fasih
pushed a commit
to fasih/cpython
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stefan Behnel reported that cf_feature_version is used even when
PyCF_ONLY_AST is not set. This is against the intention and against the
documented behavior, so it's been fixed. Includes a test contributed by Stefan.
https://bugs.python.org/issue35975