bpo-41056: Fix a possible MemoryError leak within zoneinfo. #21007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was detected by coverity as a REVERSE_INULL issue.
Coverity CID 1464644
Member
|
I don't have time to look at this in any detail until tomorrow, but I think @tiran made essentially the same patch in #21003. That one got here first, but this one has a news entry. Looks simple enough, though, if y'all want to decide which patch to move forward with, the fact that you both came up with the exact same solution is probably a good enough "review". 😛 |
tiran
approved these changes
Jun 22, 2020
Contributor
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
|
Sorry @gpshead, I had trouble checking out the |
pganssle
pushed a commit
to pganssle/cpython
that referenced
this pull request
Jun 23, 2020
…thonGH-21007) This was detected by our Coverity scan as a REVERSE_INULL issue. Automerge-Triggered-By: @gpshead (cherry picked from commit d780fa7) Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
GH-21083 is a backport of this pull request to the 3.9 branch. |
pganssle
added a commit
that referenced
this pull request
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was detected by our Coverity scan as a REVERSE_INULL issue.
https://bugs.python.org/issue41056
Automerge-Triggered-By: @gpshead