Skip to content

bpo-26407: Do not mask errors in csv.#20536

Merged
serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka:csv-errors-in-iter
Jun 22, 2020
Merged

bpo-26407: Do not mask errors in csv.#20536
serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka:csv-errors-in-iter

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented May 30, 2020 •
edited
Loading

Unexpected errors in calling the __iter__ method are no longer
masked by TypeError in csv.reader(), csv.writer.writerow() and
csv.writer.writerows().

https://bugs.python.org/issue26407

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels May 30, 2020
@serhiy-storchaka
bpo-26407: Do not mask errors in csv.
1f86347 
Unexpected errors in calling the __iter__ method are no longer
masked by TypeError in csv.reader(), csv.writer.writerow() and
csv.writer.writerows().
aeros
aeros reviewed Jun 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with directly raising other exceptions from __iter__ rather than suppressing them w/ TypeError, as it can easily obfuscate bugs. The more general discussion will likely have to take place somewhere like python-dev, but for now, I think changing csv.writerow() has a narrow enough scope.

+1, other than a comment/question on the C changes.

@serhiy-storchaka serhiy-storchaka merged commit c88239f into python:master Jun 22, 2020
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 22, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8, 3.9.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the csv-errors-in-iter branch June 22, 2020 08:22
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jun 22, 2020

GH-21047 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 22, 2020

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c88239f864a27f673c0f0a9e62d2488563f9d081 3.8

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 22, 2020

Sorry @serhiy-storchaka, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c88239f864a27f673c0f0a9e62d2488563f9d081 3.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2020
@serhiy-storchaka @miss-islington
bpo-26407: Do not mask errors in csv. (pythonGH-20536)
b5cbe98 
Unexpected errors in calling the __iter__ method are no longer
masked by TypeError in csv.reader(), csv.writer.writerow() and
csv.writer.writerows().
(cherry picked from commit c88239f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 22, 2020

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c88239f864a27f673c0f0a9e62d2488563f9d081 3.6

miss-islington added a commit that referenced this pull request Jun 22, 2020
@miss-islington @serhiy-storchaka
bpo-26407: Do not mask errors in csv. (GH-20536)
5606d55 
Unexpected errors in calling the __iter__ method are no longer
masked by TypeError in csv.reader(), csv.writer.writerow() and
csv.writer.writerows().
(cherry picked from commit c88239f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 22, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 22, 2020

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c88239f864a27f673c0f0a9e62d2488563f9d081 3.8

fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@serhiy-storchaka @fasihahmad
bpo-26407: Do not mask errors in csv. (pythonGH-20536)
8380a2c 
Unexpected errors in calling the __iter__ method are no longer
masked by TypeError in csv.reader(), csv.writer.writerow() and
csv.writer.writerows().
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 31, 2020

GH-24021 is a backport of this pull request to the 3.8 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 31, 2020
@serhiy-storchaka
[3.8] bpo-26407: Do not mask errors in csv. (pythonGH-20536)
d65ac01 
Unexpected errors in calling the __iter__ method are no longer
masked by TypeError in csv.reader(), csv.writer.writerow() and
csv.writer.writerows()..
(cherry picked from commit c88239f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jan 1, 2021
@serhiy-storchaka
[3.8] bpo-26407: Do not mask errors in csv. (GH-20536) (GH-24021)
6dffa67 
Unexpected errors in calling the __iter__ method are no longer
masked by TypeError in csv.reader(), csv.writer.writerow() and
csv.writer.writerows().
(cherry picked from commit c88239f)
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aeros aeros aeros left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @aeros @the-knights-who-say-ni