bpo-40645: Deprecated internal details of hmac.HMAC (GH-20132) #20132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The :class:`hmac.HMAC` exposes internal implementation details. The attributes ``digest_cons``, ``inner``, and ``outer`` are deprecated and will be removed in the future. Signed-off-by: Christian Heimes <christian@python.org>
gpshead
approved these changes
May 16, 2020
Contributor
|
Sorry, I can't merge this PR. Reason: |
Member
Author
|
@gpshead @miss-islington wants another ACK from you. |
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The :class:
hmac.HMACexposes internal implementation details. Theattributes
digest_cons,inner, andouterare deprecated and willbe removed in the future.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue40645
Automerge-Triggered-By: @tiran