Skip to content

bpo-40263: Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl#19501

Merged
zooba merged 1 commit intopython:mainfrom
mingwandroid:master-fix-bpo40263
Jul 28, 2021
Merged

bpo-40263: Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl#19501
zooba merged 1 commit intopython:mainfrom
mingwandroid:master-fix-bpo40263

Conversation

@mingwandroid
Copy link
Contributor

@mingwandroid mingwandroid commented Apr 13, 2020 •
edited by taleinat
Loading

Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl

https://bugs.python.org/issue40263

@mingwandroid mingwandroid changed the title Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl [bpo-40263](https://bugs.python.org/issue40263): Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl Apr 13, 2020
@cbezault
Copy link

cbezault commented Apr 13, 2020 •
edited
Loading

It's unclear to me why the -1 is needed? Do we need to reserve a slot for some other handle?

EDIT: I see it now, though it's unfortunate that we get limited to 63 even in non-main threads.

@cbezault cbezault mentioned this pull request Apr 13, 2020
Closed
@mingwandroid mingwandroid mentioned this pull request Apr 14, 2020
Open
@aeros aeros changed the title [bpo-40263](https://bugs.python.org/issue40263): Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl bpo-40263: Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl Apr 15, 2020
@taleinat
Copy link
Contributor

taleinat commented Sep 18, 2020

@zooba, you mentioned on b.p.o. that this was a good fix. Want to review this?

@nehaljwani
Copy link

nehaljwani commented Nov 14, 2020

Got hit by this again, would be great if this patch is merged upstream!

@FaustinCarter
Copy link

FaustinCarter commented Nov 14, 2020

Plus one for please merge! Currently having to work around this.

@mingwandroid
Copy link
Contributor Author

mingwandroid commented Nov 15, 2020

@nehaljwani you aren't using anaconda python? /me cries. 😀

@nehaljwani
Copy link

nehaljwani commented Nov 15, 2020

@mingwandroid I am, an upgrade to the patched build resolved the issue, however I'd still like to see this merged 😄

@mingwandroid
Copy link
Contributor Author

mingwandroid commented Jan 10, 2021

Is this trivial, somewhat important fix really going to make it to 1 year old before anyone reviews it? Ping @zooba

@mingwandroid
Copy link
Contributor Author

mingwandroid commented Apr 4, 2021

Pinging @zooba for a review.

@zooba zooba closed this Jul 28, 2021
@zooba zooba reopened this Jul 28, 2021
@zooba
Copy link
Member

zooba commented Jul 28, 2021

Sorry that I missed all the pings. Wish I could have resolved this while Ray was still with us to see it.

@zooba zooba merged commit 92b5dc7 into python:main Jul 28, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jul 28, 2021

Thanks @mingwandroid for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

bedevere-bot commented Jul 28, 2021

GH-27428 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 28, 2021
@bedevere-bot
Copy link

bedevere-bot commented Jul 28, 2021

GH-27429 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2021
@mingwandroid @miss-islington
bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObject…
e22b700 
…s_impl (pythonGH-19501)

(cherry picked from commit 92b5dc7)

Co-authored-by: Ray Donnelly <mingw.android@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2021
@mingwandroid @miss-islington
bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObject…
84d552b 
…s_impl (pythonGH-19501)

(cherry picked from commit 92b5dc7)

Co-authored-by: Ray Donnelly <mingw.android@gmail.com>
miss-islington added a commit that referenced this pull request Jul 28, 2021
@miss-islington @mingwandroid
bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObject…
bccb7b9 
…s_impl (GH-19501)

(cherry picked from commit 92b5dc7)

Co-authored-by: Ray Donnelly <mingw.android@gmail.com>
zooba pushed a commit that referenced this pull request Jul 28, 2021
@miss-islington @mingwandroid
bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObject…
899e37b 
…s_impl (GH-19501)

(cherry picked from commit 92b5dc7)

Co-authored-by: Ray Donnelly <mingw.android@gmail.com>
@jaraco jaraco mentioned this pull request Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cbezault cbezault cbezault approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@mingwandroid @cbezault @taleinat @nehaljwani @FaustinCarter @zooba @miss-islington @bedevere-bot @the-knights-who-say-ni