[3.6] bpo-39503: CVE-2020-8492: Fix AbstractBasicAuthHandler (GH-18284)#19304
Merged
ned-deily merged 1 commit intopython:3.6from Apr 3, 2020
vstinner:urllib_basic_auth_regex36
Merged
[3.6] bpo-39503: CVE-2020-8492: Fix AbstractBasicAuthHandler (GH-18284)#19304ned-deily merged 1 commit intopython:3.6from vstinner:urllib_basic_auth_regex36
ned-deily merged 1 commit intopython:3.6from
vstinner:urllib_basic_auth_regex36
Conversation
Member
Author
|
@ned-deily: Would you mind to merge this security fix? |
Member
Author
I don't think that this job is supposed to run: I created https://bugs.python.org/issue40156 and #19306 to disable this job. |
Member
Author
|
@ned-deily: so if you cannot merge this PR because of CodeCov, you can use PR #19306. |
The AbstractBasicAuthHandler class of the urllib.request module uses an inefficient regular expression which can be exploited by an attacker to cause a denial of service. Fix the regex to prevent the catastrophic backtracking. Vulnerability reported by Ben Caller and Matt Schwager. AbstractBasicAuthHandler of urllib.request now parses all WWW-Authenticate HTTP headers and accepts multiple challenges per header: use the realm of the first Basic challenge. Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 0b297d4)
Member
Author
|
PR rebased on top of commit ebeabb5 (disable Codecov CI). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AbstractBasicAuthHandler class of the urllib.request module uses
an inefficient regular expression which can be exploited by an
attacker to cause a denial of service. Fix the regex to prevent the
catastrophic backtracking. Vulnerability reported by Ben Caller
and Matt Schwager.
AbstractBasicAuthHandler of urllib.request now parses all
WWW-Authenticate HTTP headers and accepts multiple challenges per
header: use the realm of the first Basic challenge.
Co-Authored-By: Serhiy Storchaka storchaka@gmail.com
(cherry picked from commit 0b297d4)
https://bugs.python.org/issue39503