Skip to content

bpo-39656: Ensure bin/python3.# is always present in virtual environments#19030

Merged
vsajip merged 1 commit intopython:masterfrom
asottile:versioned_venv_executable
Mar 17, 2020
Merged

bpo-39656: Ensure bin/python3.# is always present in virtual environments#19030
vsajip merged 1 commit intopython:masterfrom
asottile:versioned_venv_executable

Conversation

@asottile
Copy link
Copy Markdown
Contributor

@asottile asottile commented Mar 16, 2020 •
edited by bedevere-bot
Loading

@asottile asottile requested a review from vsajip as a code owner March 16, 2020 18:40
@gaborbernat
Copy link
Copy Markdown
Contributor

gaborbernat commented Mar 16, 2020

We already do this virtualenv, I think it's a good Idea 👍

@vsajip vsajip merged commit 58ec58a into python:master Mar 17, 2020
@asottile asottile deleted the versioned_venv_executable branch March 17, 2020 07:47
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 17, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x has failed when building commit 58ec58a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/101/builds/532) and take a look at the build logs.
  4. Check if the failure is related to this commit (58ec58a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/101/builds/532

Failed tests:

  • test_concurrent_futures

Failed subtests:

  • test_crash - test.test_concurrent_futures.ProcessPoolSpawnExecutorDeadlockTest

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_concurrent_futures.py", line 1119, in test_crash
    executor.shutdown(wait=True)
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/concurrent/futures/process.py", line 721, in shutdown
    self._executor_manager_thread_wakeup.wakeup()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/concurrent/futures/process.py", line 93, in wakeup
    self._writer.send_bytes(b"")
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/multiprocessing/connection.py", line 205, in send_bytes
    self._send_bytes(m[offset:offset + size])
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/multiprocessing/connection.py", line 416, in _send_bytes
    self._send(header + buf)
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/multiprocessing/connection.py", line 373, in _send
    n = write(self._handle, buf)
OSError: [Errno 9] Bad file descriptor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asottile @gaborbernat @bedevere-bot @vsajip @the-knights-who-say-ni