bpo-28577: Special case added to IP v4 and v6 hosts for /32 and /128 networks#18757
bpo-28577: Special case added to IP v4 and v6 hosts for /32 and /128 networks#18757ethanfurman merged 7 commits intopython:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Pete Wicken <petewicken@gmail.com>
Added IPv6 update to news
ethanfurman
left a comment
There was a problem hiding this comment.
According to Travis there is a file with whitespace issues, and some problem with the docs.
Otherwise, it looks good to me!
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @ethanfurman: please review the changes made to this pull request. |
ethanfurman
left a comment
There was a problem hiding this comment.
Looks good!
I'll give it a couple days in case somebody else want to chime in. Feel free to ping me early next week if this PR is still open.
No updates on here or on BPO - do we want to leave it open a bit longer or are you happy to sign off on it? |
|
Thanks @JamoBox for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
Thanks @JamoBox for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Sorry, @JamoBox and @ethanfurman, I could not cleanly backport this to |
|
Sorry @JamoBox and @ethanfurman, I had trouble checking out the |
|
Will need to do the backports after the RCs are published. |
|
Hi there, sorry for the noise; it looks like the backports did not happen, did they? |
… /128 networks (pythonGH-18757) The `.hosts()` method now returns the single address present in a /32 or /128 network.. (cherry picked from commit 8e9c47a) Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
… /128 networks (pythonGH-18757) The `.hosts()` method now returns the single address present in a /32 or /128 network.. (cherry picked from commit 8e9c47a) Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
|
GH-25533 is a backport of this pull request to the 3.7 branch. |
… /128 networks (pythonGH-18757) The `.hosts()` method now returns the single address present in a /32 or /128 network.. (cherry picked from commit 8e9c47a) Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
Yep, totally forgot about these - PRs are in for 3.6, 3.7 and 3.8 now. Thanks! |
Calling hosts() on a /32 IPv4Network now returns a list containing the IPv4Address instead of an empty list.
The same also happens for /128 IPv6Networks
https://bugs.python.org/issue28577