Skip to content

Conversation

@ameily
Copy link
Contributor

@ameily ameily commented Jan 24, 2020

Honor the Python path when a virtualenv is active on Windows.

https://bugs.python.org/issue39439

@csabella csabella requested a review from zooba January 27, 2020 12:22
@zooba zooba merged commit 0be3246 into python:master Jan 28, 2020
@miss-islington
Copy link
Contributor

Thanks @ameily for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Thanks @ameily for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 28, 2020
…nGH-18158)

(cherry picked from commit 0be3246)

Co-authored-by: Adam Meily <ameily@users.noreply.github.com>
@bedevere-bot
Copy link

GH-18237 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Thanks @ameily for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @ameily for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 28, 2020
…nGH-18158)

(cherry picked from commit 0be3246)

Co-authored-by: Adam Meily <ameily@users.noreply.github.com>
@bedevere-bot
Copy link

GH-18238 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jan 28, 2020
)

(cherry picked from commit 0be3246)

Co-authored-by: Adam Meily <ameily@users.noreply.github.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants